-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop 0.4.4-beta.*
#35
Comments
And/Or setting [lib]
name = "proconio_beta" This renaming is also useful for using both 0.3 and 0.4 on AtCoder with a bundling tool such as cargo-equip. use proconio::input; // enough for this problem
//use proconio_beta::input; //use proconio::input;
use proconio_beta::input; // I want to use a new feature for this problem |
Example: https://docs.rs/salsa |
Thank you for a good opinion! First of all, I also think we should make it hard to use v0.4 to AtCoder users. I'm concerning, however, that using prerelease versioning (including renaming to
This is just my thought. What do you think? |
That's true. Yanked crates cannnot be resolved without Cargo.lock, though they are still even downloadable if Cargo.lock remains(※). Just yanking previous v0.4.* would defeat the purpose. (※) How to confirm this❯ # crossbeam v0.5.2 is yanked
❯ rm ~/.cargo/registry/cache/git.luolix.top-1ecc6299db9ec823/crossbeam-channel-0.5.2.crate
❯ cargo init
Created binary (application) package
❯ cargo add 'crossbeam-channel@=0.5.0'
Updating 'https://github.com/rust-lang/crates.io-index' index
Adding crossbeam-channel =0.5.0 to dependencies.
Features:
+ crossbeam-utils/std
+ std
- crossbeam-utils
❯ cargo generate-lockfile
Updating crates.io index
❯ sed 's/"=0\.5\.0"/"0.5.2"/' -i ./Cargo.toml
❯ sed \
> -e '/^name = "crossbeam-channel"$/{n;s/0\.5\.0/0.5.2/}' \
> -e 's/"dca26ee1f8d361640700bde38b2c37d8c22b3ce2d360e1fc1c74ea4b0aa7d775"/"e54ea8bc3fb1ee042f5aace6e3c6e025d3874866da222930f70ce62aceba0bfa"/' \
> -Ei ./Cargo.lock
❯ cargo check
Downloaded crossbeam-channel v0.5.2
Downloaded 1 crate (87.8 KB) in 1.40s
Compiling crossbeam-utils v0.8.8
Checking cfg-if v1.0.0
Checking lazy_static v1.4.0
Checking crossbeam-channel v0.5.2
Checking pkg v0.1.0 (/tmp/pkg)
Finished dev [unoptimized + debuginfo] target(s) in 2.58s How about this?:
I've forgotten CafeCoder. This competitive programming service currently returns HTTP 500, but if I remember correctly, it is providing proconio v0.4. |
Thanks for detailed explanation. Deprecating v0.4 still doesnt seem a good way to me, considering that v0.4 is in fact better version for new users and there's actually another service (CafeCoder) using this, but adding warning is a good idea! So how about this: adding |
Yes, switching the warning is the most reasonable way to me, but how about adding non-default proconio may be used as a dev-dependency for library crates that are bundled by cargo-equip, cargo-executable-payload, or cargo-atcoder. Suppressing the warning in such case might be difficult because features are easy to enable but hard to disable. |
Maybe we should release new versions of crates as
0.4.4-beta.*
.Currently, some people do not seem to use 0.3 but 0.4 for AtCoder. Adding new features such as #26 and #27 may lead to "what the hell my program compiles with Rust 1.42 on the local machine but the submission is CE".
Making the versions
beta
will prevent such a situation because both the (currently unstable) built-incargo add
command and thecargo-add
command from cargo-edit does not resolve-beta
versions without explicit specification.The text was updated successfully, but these errors were encountered: