Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 fixed transition animation in accordion to match zhweb #245

Merged
merged 4 commits into from
Nov 25, 2024
Merged

fix: 🐛 fixed transition animation in accordion to match zhweb #245

merged 4 commits into from
Nov 25, 2024

Conversation

resmartiZH
Copy link
Collaborator

@daenub, this fixes issue #244

daenub
daenub requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@daenub daenub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix!

I just saw that in firefox the divider is not visible anymore.

Otherwise it looks good to me!

src/components/accordion/Accordion.js Show resolved Hide resolved
src/components/accordion/Accordion.js Outdated Show resolved Hide resolved
@resmartiZH
Copy link
Collaborator Author

Thanks for the review. I fixed the bug in firefox and all the other details.

@daenub daenub merged commit 11950f1 into main Nov 25, 2024
@daenub daenub deleted the 244-unneeded-accordion-transitions branch November 25, 2024 09:53
@daenub daenub mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daenub daenub daenub requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@resmartiZH @daenub