Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align core types with execution spec #733

Merged
merged 13 commits into from
Sep 29, 2024
Merged

Align core types with execution spec #733

merged 13 commits into from
Sep 29, 2024

Commits on Sep 25, 2024

  1. Align core types with execution spec

    Since these types were written, we've gained an executable spec:
    
    https://github.com/ethereum/execution-specs
    
    This PR aligns some of the types we use with this spec to simplify
    comparisons and cross-referencing.
    
    Using a `distinct` type is a tradeoff between nim ergonomics, type
    safety and the ability to work around nim quirks and stdlib weaknesses.
    
    In particular, it allows us to overload common functions such as `hash`
    with correct and performant versions as well as maintain control over
    string conversions etc at the cost of a little bit of ceremony when
    instantiating them.
    
    Apart from distinct byte types, `Hash32`, is introduced in lieu of the
    existing `Hash256`, again aligning this commonly used type with the spec
    which picks bytes rather than bits in the name.
    arnetheduck committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b4d1ef5 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Configuration menu
    Copy the full SHA
    d61622f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    34eaa91 View commit details
    Browse the repository at this point in the history
  3. more cleanups

    arnetheduck committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e9ae016 View commit details
    Browse the repository at this point in the history
  4. fixes

    arnetheduck committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a3c9536 View commit details
    Browse the repository at this point in the history
  5. oops

    arnetheduck committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9e275a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. uint64 for NetworkId

    arnetheduck committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    83d639d View commit details
    Browse the repository at this point in the history
  2. updates

    arnetheduck committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    cdb3601 View commit details
    Browse the repository at this point in the history
  3. bloom: fix missing keccak

    arnetheduck committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    899c0f7 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Configuration menu
    Copy the full SHA
    13f7102 View commit details
    Browse the repository at this point in the history
  2. move keys test to common

    arnetheduck committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    68d1cb5 View commit details
    Browse the repository at this point in the history
  3. keys import

    arnetheduck committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    9b1b651 View commit details
    Browse the repository at this point in the history
  4. oops

    arnetheduck committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3908931 View commit details
    Browse the repository at this point in the history