Add ping protocol support and use for keep-alive #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarth
approved these changes
Jun 15, 2021
Good idea. See vacp2p/rfc#400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #534
It adds libp2p
pingprotocol support for Waku v2, mounts it on all nodes and usespingas the underlying mechanism for keep-alive functionality.In order to use the
unstablebranch ofnim-libp2p, theWakuPeerStorehad to be separated from the underlying libp2pPeerStore. See this comment for background. #622 keeps track of the effort to reintegrate the libp2pPeerStoreinto Waku v2.