Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PCRE support #50

Open
tersec opened this issue Sep 26, 2022 · 0 comments
Open

Remove PCRE support #50

tersec opened this issue Sep 26, 2022 · 0 comments

Comments

@tersec
Copy link
Contributor

tersec commented Sep 26, 2022

It's effectively vestigial.

It's there because https://nim-lang.org/docs/re.html depends on PCRE, but since 0.6.4:

  • The PCRE library is no longer necessary for building Nimbus.

This would involve removing it from README.me and

# avoid a "libpcre.so.3: cannot open shared object file: No such file or directory" message, where possible
LINK_PCRE ?= 1
ifeq ($(LINK_PCRE), 1)
ifneq ($(OS), Windows_NT)
ifneq ($(strip $(shell uname)), Darwin)
ifeq ($(PARTIAL_STATIC_LINKING), 1)
NIM_PARAMS := $(NIM_PARAMS) -d:usePcreHeader --passL:-l:libpcre.a
else
NIM_PARAMS := $(NIM_PARAMS) -d:usePcreHeader --passL:-lpcre
endif
endif
endif
endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant