Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

history-index is not returned by browser service #1544

Closed
yenda opened this issue Jul 25, 2019 · 2 comments · Fixed by #1545
Closed

history-index is not returned by browser service #1544

yenda opened this issue Jul 25, 2019 · 2 comments · Fixed by #1545
Labels
E:Bug MVP

Comments

@yenda
Copy link
Contributor

yenda commented Jul 25, 2019 •
edited by 0xc1c4da
Loading

Problem

history-index key is not returned by browser service when calling browsers_getBrowsers

Acceptance Criteria

history-index key is returned as well
@yenda
Copy link
Contributor Author

yenda commented Jul 25, 2019

My understanding is that omitempty considers 0 to be empty, so history-index is not returned when the index is 0. Taking this into consideration I made a fix on status-react side which considers history-index to be 0 if there is none, so this is very low priority.

@dshulyak
Copy link
Contributor

@yenda yes. i realized that it will be omitted when you opened an issue. easy fix so i will push it

@dshulyak dshulyak mentioned this issue Jul 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:Bug MVP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't omit history index when the value is 0 status-im/status-go
2 participants
@yenda @dshulyak