-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: connection health should be shard specific #4628
Comments
Yeah, this is an issue we have now regardless of which approach to follow with sharding. Ideally we should have separate banners of health indicators in the clients with one used for 1:1, group chats, communities with unassigned shards and unprotected shard for requests to join (shards 16/32 and 16/64); and then for each community that has an assigned shard, an specific health check for them. |
cc: @iurimatias as desktop changes would be needed too depending on solution proposals |
Relay mode connection health reporting is already addressed in waku-org/go-waku#1021 |
Problem
While going through the code debugging an issue, i had noticed that connection state is shown purely based on peer connections that are available. This would make sense when a single pubsubTopic is used, but with sharding and communities having their own shards/pubsubTopics or sharing shards, connection state or health should be shown per shard/pubsubTopic.
Towards this end i forsee following changes to be made:
How this health/connection status has to be shown in status-desktop and mobile GUI is upto respective teams. Because this is specific to each community or shard.
Also, few points to keep in mind is how to indicate below scenarios such as :
Implementation
status-go shall not rely on individual peer connection or disconnection notification rather depend on peerConnHealth (which would just notify health status for a particular shard/pubsubTopic). We can consider 3 states for
peerConnHealth
:Minimally-Healthy
(e.g: less than 4 peers are connected in relay-mode , 1 filter peer connection and 1 lightpush peer is available)Sufficiently-Healthy
(e.g: min 4 peers are connected in relay-mode, more than 1 filter peer connection and atleast 2 lightpush peers available)UnHealthy
(no peer connections are available in relay-mode, no filter or lightpush peers available in light-mode)The following would indicate the
peerConnHealth
:Thoughts @richard-ramos @plopezlpz @kaichaosun @cammellos @vitvly
Note: More details regarding the approach on how reporting would be done shall be included as part of waku-org/go-waku#1021
Acceptance Criteria
TBD - once approach is finalized
The text was updated successfully, but these errors were encountered: