Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single flow to send a transaction for remote and local nodes #529

Closed
adambabik opened this issue Jan 3, 2018 · 1 comment
Closed

Comments

@adambabik
Copy link
Contributor

Problem

It is described in this comment.

The problem is that having two separate flows to send a transaction introduces subtle differences that may be hard to debug, maintain and can lead to inconsistencies.

Implementation

Create a single flow in status-go to send all transactions via eth_sendRawTransaction regardless which node is used.

Acceptance Criteria

  1. There is a single flow to send a transaction,
  2. The whole code related to gas estimation, getting a nonce etc. is in one place,
  3. Sending a transaction works with local and remote nodes.
@status-open-bounty
Copy link

status-open-bounty commented Jan 3, 2018

Balance: 0.000000 ETH
Tokens: SNT: 870.00
Contract address: 0x9ee854507d03f592ec5bfe47e214a34f6e884c16
Network: Mainnet
Paid to: dshulyak
Visit https://openbounty.status.im to learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants