Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow configure HTTPVirtualHosts and HTTPCors settings #1236

Merged
merged 1 commit into from
Oct 12, 2018
Merged

allow configure HTTPVirtualHosts and HTTPCors settings #1236

merged 1 commit into from
Oct 12, 2018

Conversation

adambabik
Copy link
Contributor

closes #1232

@status-github-bot
Copy link

status-github-bot bot commented Oct 11, 2018 •
edited by adambabik
Loading

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

dshulyak
dshulyak approved these changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@dshulyak dshulyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adambabik @pombeirp what about making ethereum.NodeConfig a part of the Status's NodeConfig? Do you know if there are any obstacles or reasons not to enable that?

@adambabik
Copy link
Contributor Author

@dshulyak no, it's definitely doable. We use NodeConfig but it lost its meaning long time ago as we have everything in there. Some name refactoring and splitting it further would be definitely useful and would save us passing/duplicating properties from one config struct to geth.NodeConfig.

@adambabik adambabik merged commit 20f8f1f into develop Oct 12, 2018
@adambabik adambabik deleted the ISSUE-1232/spec-virtualhosts-and-cors branch October 12, 2018 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedropombeiro pedropombeiro pedropombeiro approved these changes

@dshulyak dshulyak dshulyak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config: allow specifying virtual hosts and CORS
3 participants
@adambabik @pedropombeiro @dshulyak