-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goerli: contracts for testnet #2741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (30)
|
churik
force-pushed
the
goerli-transition
branch
2 times, most recently
from
July 13, 2022 08:55
84849fb
to
7e242ef
Compare
This was referenced Jul 13, 2022
churik
force-pushed
the
goerli-transition
branch
2 times, most recently
from
July 19, 2022 12:26
e9cf09d
to
7fedc97
Compare
churik
force-pushed
the
goerli-transition
branch
from
July 20, 2022 05:36
7fedc97
to
d8d3547
Compare
@Samyoul can you please help me with lint? not sure what happened there and how my changes may cause this |
@churik I've found the issue, it is the most ridiculous linting issue I've ever seen. Line 1426 should be:
The fail is because the linter wants consistent indentation chars and that line has a mix of spaces and tabs, I think it expects |
Samyoul
approved these changes
Jul 20, 2022
churik
force-pushed
the
goerli-transition
branch
2 times, most recently
from
July 20, 2022 12:04
af4b077
to
5787aad
Compare
churik
force-pushed
the
goerli-transition
branch
from
July 20, 2022 12:15
5787aad
to
3cd92fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added contracts, required for Goerli testnet: ENS, MiniMeToken, StickerMarket, StickerPacks
Corresponding PR in status-react: status-im/status-mobile#13660
PR won't affect status-desktop client, so testing can be skipped.