Skip to content

Commit

Permalink
Composer - Link previews - Adjust for upcoming API breaking changes i…
Browse files Browse the repository at this point in the history
…n status-go (#17573)

Adapt the JSON RPC response to the new shape returned by `wakuext_unfurlURLs` on
v0.170.0. The changes were introduced PR
status-im/status-go#4033. There are no behavioral
changes in the API as far as mobile is concerned at the moment.
  • Loading branch information
ilmotta authored Oct 13, 2023
1 parent d01c337 commit 9078c3b
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@

(rf/defn unfurl-parsed-urls-success
{:events [:link-preview/unfurl-parsed-urls-success]}
[{:keys [db]} request-id new-previews]
[{:keys [db]} request-id {new-previews :linkPreviews}]
(when (= request-id (get-in db [:chat/link-previews :request-id]))
(let [new-previews (map data-store.messages/<-link-preview-rpc new-previews)
curr-previews (get-in db [:chat/link-previews :unfurled])
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,17 +139,18 @@
{:request-id request-id
:unfurled []
:cache {}}}}]
(is (nil? (events/unfurl-parsed-urls-success cofx "banana" [preview-github])))))
(is (nil? (events/unfurl-parsed-urls-success cofx "banana" {:linkPreviews [preview-github]})))))

(testing "reconciles new previews with existing ones"
(let [cofx {:db {:chat/link-previews
{:request-id request-id
:unfurled [preview-github
{:url url-gitlab :loading? true}]
:cache {url-github preview-github}}}}
{db :db} (events/unfurl-parsed-urls-success cofx
request-id
[preview-gitlab])]
{db :db} (events/unfurl-parsed-urls-success
cofx
request-id
{:linkPreviews [preview-gitlab]})]
(is (= {:chat/link-previews
{:request-id request-id
:unfurled [preview-github preview-gitlab]
Expand All @@ -165,10 +166,11 @@
preview-youtube
{:url url-gitlab :loading? true}]
:cache {(:url preview-youtube) preview-youtube}}}}
{db :db} (events/unfurl-parsed-urls-success cofx
request-id
[preview-github
preview-youtube])]
{db :db} (events/unfurl-parsed-urls-success
cofx
request-id
{:linkPreviews [preview-github
preview-youtube]})]
(is (= {:chat/link-previews
{:request-id request-id
:unfurled [preview-github preview-youtube]
Expand Down
6 changes: 3 additions & 3 deletions status-go-version.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"_comment": "Instead use: scripts/update-status-go.sh <rev>",
"owner": "status-im",
"repo": "status-go",
"version": "v0.168.1",
"commit-sha1": "9034f0a984601d71e40d0aa846fbc5e4d01017cd",
"src-sha256": "1niics10a0p3dnlfr011sqf5prrjilv6kjplnc2c51q2pw6fv35h"
"version": "v0.170.0",
"commit-sha1": "aded258ccb68f88dc995e22f8b4e06157bb642db",
"src-sha256": "1wdc814yx6qam2ngrh119hm63bgjigqi4cpiawy2i0ywk47qwdbg"
}

0 comments on commit 9078c3b

Please sign in to comment.