Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No conversion for WETH is assests in wallet #11037

Closed
qoqobolo opened this issue Aug 5, 2020 · 7 comments
Closed

No conversion for WETH is assests in wallet #11037

qoqobolo opened this issue Aug 5, 2020 · 7 comments

Comments

@qoqobolo
Copy link
Contributor

qoqobolo commented Aug 5, 2020

Bug Report

Problem

Сonversion for WETH in wallet no displayed. Adress for checking conversion for this asset on Etherscan: 0xcf2272205cc0cf96Cfbb9Dd740BD681D1E86901E

Actual behavior

Снимок экрана 2020-08-05 в 4 17 39 PM

  • Status version: Release 1.5
@flexsurfer
Copy link
Member

cryptocompare api doesn't support WETH https://min-api.cryptocompare.com/data/price?fsym=WETH&tsyms=USD,JPY,EUR

@hesterbruikman
Copy link
Contributor

See also #10695 (comment) for a check with Cryptocompare on Manage assets to inform the user of fiat values not available

@churik
Copy link
Member

churik commented Aug 24, 2020

@hesterbruikman
WETH (which is the really common case on exchanges) or any asset that already presented (not added) in our assets list probably at least show nothing or use another source (not cryptocompare)?

It seems weird to me to have tokens / currencies that are not supported in case if they are already hardcoded in our assets list.

@hesterbruikman
Copy link
Contributor

Agreed, I think WETH is one of the exceptions where it is commonly used so we want to offer not having to add it manually. At the same time it's supported, but not fully supported. We should probably still check if the token fiat value is supported given the fiat value you have selected.

@flexsurfer
Copy link
Member

i didn't find a list of supported tokens by Cryptocompare, so probably not only weth from our list is not supported, but i figured out that WETH is not traded on any centralized exchange , thats why there is no price, it is traded on decentralized uniswap, so if we want its price we should get it somehow from uniswap contract i guess

@flexsurfer
Copy link
Member

related issue #9140

@cammellos
Copy link
Contributor

Seems like this can be closed, @flexsurfer feel free to re-open if other actions are required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants