Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message input: issues, mentions #14362

Closed
pavloburykh opened this issue Nov 14, 2022 · 10 comments · Fixed by #14450
Closed

Message input: issues, mentions #14362

pavloburykh opened this issue Nov 14, 2022 · 10 comments · Fixed by #14450
Assignees
Milestone

Comments

@pavloburykh
Copy link
Contributor

pavloburykh commented Nov 14, 2022

This is a list of some input field bugs.

ISSUE 1 (Android only) Mention list is not shown after typing @

Steps:

  1. Type @ symbol in the input field
  2. See if mention list is shown

Actual result: Mention list is not shown

Expected result: Mention list appears after typing @

telegram-cloud-document-2-5444956798232568554.mp4

ISSUE 2 (Android only) Input field expands to the full heights of the screen after clearing it

Steps:

  1. Type some text in the input field
  2. Clear text in the input field
  3. Observe the result

Actual result: input field expands to the full heights of the screen when the keyboard is active

Expected result: input field preserves it's original size

telegram-cloud-document-2-5444956798232568523.mp4

ISSUE 3 (Android/IOS) Input field containing multiline message scales down when closing keyboard

Steps:

  1. Type some multiline message in the input field
  2. Close the keyboard
  3. Observe the behaviour of the input field

Actual result: Input field scales down, the message becomes invisible (only first 2 lines are partially visible). Overall, manual expanding/collapsing of the input field does not work smoothly which is resulting in poor user experience.

IOS

telegram-cloud-document-2-5444956798232568569.mp4

Android

telegram-cloud-document-2-5444956798232568563.mp4

ISSUE 4 The messages and contact requests are not shown if one of the device change his time within settings

Steps:

  1. Send contact request as USER_A to USER_B
  2. Accept the request
  3. Create any chat (1-1, group, public, community)
  4. Change time to +1 within the settings of your device using USER_A
  5. Send a message to USER_B in any created chat
  6. Send contact request to USER_C

Actual result:

  • USER_A and USER_B don't see each other messages after the time is changed within device settings
  • USER_C does not see a contact request of USER_A

Expected result:

  • Users see messages and contact requests of each other even if the time for a particular device is changed

OS Both Android and IOS

@churik
Copy link
Member

churik commented Nov 14, 2022

@churik churik changed the title Input field bugs Message input: issues, mentions Nov 14, 2022
@OmarBasem OmarBasem self-assigned this Nov 15, 2022
@OmarBasem OmarBasem removed their assignment Nov 15, 2022
@churik
Copy link
Member

churik commented Nov 24, 2022

from #14432
The chat sheet should expand as the user types new lines. It no longer does that as of today.

22-11-23-22-58-10.mp4

@ibrkhalil
Copy link
Contributor

ibrkhalil commented Nov 27, 2022

Issue one was resolved by
#14442
UPDATE:
I was able to reproduce again .. Working on it
UPDATE:
Turns out the fix I did only worked for iOS .. I applied it to Android too

@ibrkhalil ibrkhalil self-assigned this Nov 27, 2022
@ibrkhalil
Copy link
Contributor

Can we add this issue too ?
Selection a mention doesn't autocomplete the selected user's name in the chat input
https://user-images.githubusercontent.com/33176106/204301802-e4f81c79-fa0d-4e30-84ea-9f095a228352.mp4

@ibrkhalil
Copy link
Contributor

Can we add this issue too ? Selection a mention doesn't autocomplete the selected user's name in the chat input https://user-images.githubusercontent.com/33176106/204301802-e4f81c79-fa0d-4e30-84ea-9f095a228352.mp4

Fixed, Thanks @flexsurfer

@ibrkhalil
Copy link
Contributor

from #14432 The chat sheet should expand as the user types new lines. It no longer does that as of today.

22-11-23-22-58-10.mp4

2022-11-29.21-29-03.mp4

@churik churik added this to the 1.21.0-rc.1 milestone Dec 2, 2022
@ibrkhalil
Copy link
Contributor

@pavloburykh Can you please test the first three issues, I started working on the fourth today .. I just want to check if I can improve on the older ones ?

@ibrkhalil
Copy link
Contributor

@pavloburykh I tried to reproduce the timezone issue and I couldn't

@flexsurfer
Copy link
Member

hey @pavloburykh im not sure how ISSUE 4 related to input field ?

@pavloburykh
Copy link
Contributor Author

hey @pavloburykh im not sure how ISSUE 4 related to input field ?

This one has been logged by @VladimrLitvinenko I guess, it should be logged separately if still reproducible in latest nightly. @VladimrLitvinenko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants