Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token registry to automatically get balance for address in wallet #1629

Closed
oskarth opened this issue Aug 17, 2017 · 3 comments
Closed

Token registry to automatically get balance for address in wallet #1629

oskarth opened this issue Aug 17, 2017 · 3 comments
Milestone

Comments

@oskarth
Copy link
Contributor

oskarth commented Aug 17, 2017

User story

As a token holder I want to see the tokens I own automatically. At least the common ones.

Acceptance criteria

Undefined so far.

Suggestions

  • 3esmit: Use Parity in chain smart contracts that contains the token list

  • 3esmit: Have our own in chain tokenreg list controlled by SNT holders

  • 3esmit: User configuration for his own custom tokens

  • Jarrad: token registry smart contract or use anothers, detect which network we are on and switch contract address for either, that way interface is the same

  • 3esmit: start with config file or token list from parity, if token list get too big we make other list with defaults selected, and a local userlist. I think that instead of using token list from parity, having our own token list controlled by us and later we change controller to SNT quorum (voting by holders).

Open questions

  • Non ERC20 contracts?
  • Which registry to use?
  • What if contract isn't in registry?
  • How deal with testing for non mainnet?

See also

ethereum/EIPs#22

@oskarth oskarth changed the title Token registry to automatically get balance Token registry to automatically get balance for address in wallet Aug 17, 2017
@yenda yenda added the wallet label Oct 19, 2017
@yenda yenda added this to the 0.9.13 milestone Oct 19, 2017
@jeluard
Copy link
Contributor

jeluard commented Feb 8, 2018

@oskarth Is that still relevant?

@oskarth
Copy link
Contributor Author

oskarth commented Feb 14, 2018

@jeluard Not sure, you worked on this piece of the code most recently (ERC20). WDYT? Could go either way.

@jeluard
Copy link
Contributor

jeluard commented Feb 14, 2018

We now have a dedicated idea to track this so I think we can close this issue for now.

@jeluard jeluard closed this as completed Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants