Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong buttons' background color on community home screen when overlay layer is applied (Android) #16845

Closed
pavloburykh opened this issue Aug 2, 2023 · 5 comments · Fixed by #17003
Assignees

Comments

@pavloburykh
Copy link
Contributor

Followup of #16772 cc @J-Son89

Steps:

  1. Open community home page
  2. Open Context menu bottom sheet
  3. Pay attention at cancel/3 dots buttons' background

Actual result:

photo_2023-08-01 14 36 53

telegram-cloud-document-2-5352946714577743856.mp4

Expected result:

Figma

Communities for Mobile – Figma 2023-08-01 17-30-36 ### Additional Information
  • Status version: nightly
  • Operating System: Android, iOS
@ibrkhalil
Copy link
Contributor

Blocked by #17017

@churik churik removed the blocked label Aug 29, 2023
@cammellos
Copy link
Contributor

This is not blocked anymore @ibrkhalil

@J-Son89
Copy link
Contributor

J-Son89 commented Sep 13, 2023

was this issue not fixed from @ulisesmac recent changes to that [age nav component? 🤔

@ulisesmac
Copy link
Contributor

was this issue not fixed from @ulisesmac recent changes to that [age nav component? 🤔

The page-nav component I fixed is being used inside another component:
status-im2.common.scroll-page.view/f-scroll-page-header

And it's only contemplating a switch between :blur and :photo page-nav variants according to scrolling state.
The f-scroll-page-header component is not generalized enough to display a page-nav in other variants so it is still a pending task.

@ibrkhalil
Copy link
Contributor

waiting for #17412 to get merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants