Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quo 2 slide button - implement missing variants and fix some minor UI issues #17444

Closed
J-Son89 opened this issue Sep 28, 2023 · 1 comment · Fixed by #17473
Closed

Quo 2 slide button - implement missing variants and fix some minor UI issues #17444

J-Son89 opened this issue Sep 28, 2023 · 1 comment · Fixed by #17473
Assignees
@J-Son89
Labels
design-system feature feature requests

Comments

@J-Son89
Copy link
Contributor

J-Son89 commented Sep 28, 2023

The quo2 Slider button is missing some variants - blur

Additionally fix these UI issues.

ISSUE 2 Biometric icon appears when sliding to the end
#16916 (comment)
Screenshot 2023-09-28 at 12 20 53

ISSUE 3 Placeholder text partially remains visible for a moment behind the slider
#16916 (comment)
Screenshot 2023-09-28 at 12 21 44

additionally ensure the api is matching figma as agreed in the best practices
update it's uses in the application

These issues were caught in the pr #16916
@J-Son89 J-Son89 added feature feature requests design-system labels Sep 28, 2023
@J-Son89 J-Son89 self-assigned this Oct 1, 2023
@J-Son89
Copy link
Contributor Author

J-Son89 commented Oct 1, 2023 •
edited
Loading

ISSUE 2 Biometric icon appears when sliding to the end
#16916 (comment)
is not actually be an issue - checked this with design team. There is some specifications which need to be defined for this still. So I will leave this for now but create an additional follow up issue 👍

@J-Son89 J-Son89 mentioned this issue Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@J-Son89 J-Son89

Labels
design-system feature feature requests
Projects
Do not use - tasks moved to unified Desktop / Mobile Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: slider button - add error type, blur variant and fix small ui bug status-im/status-mobile
1 participant
@J-Son89