Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design feedback for chat topbar #17509

Closed
ibrkhalil opened this issue Oct 4, 2023 · 5 comments · Fixed by #17582
Closed

Design feedback for chat topbar #17509

ibrkhalil opened this issue Oct 4, 2023 · 5 comments · Fixed by #17582
Assignees
@ibrkhalil

Comments

@ibrkhalil
Copy link
Contributor

ibrkhalil commented Oct 4, 2023 •
edited
Loading

Bug Report

Address the design review feedback from design on the comments highlighted in these Figma links.
There's a cutout that happens when scrolling to trigger the minified chat nav.

Resources

Resources
Reported at: https://www.figma.com/file/Tf5nfkYvpbnNCo4rKLK7lS?node-id=5963:43613&mode=design#567134213
https://www.figma.com/file/Tf5nfkYvpbnNCo4rKLK7lS?node-id=6142:39869&mode=design#567179730

Figma specs: https://www.figma.com/file/7KIYbhoqNGAIFonE0w9TDz/Messages-for-Mobile?type=design&node-id=8451-541849&mode=design&t=Ox3uxC14FqmagMOp-0
@ibrkhalil ibrkhalil self-assigned this Oct 4, 2023
@ibrkhalil ibrkhalil removed their assignment Oct 5, 2023
@ibrkhalil
Copy link
Contributor Author

Couldn't reproduce the wrong color one as it was merged 3 days ago here

@ibrkhalil ibrkhalil self-assigned this Oct 6, 2023
@ibrkhalil ibrkhalil changed the title Design feedback address for chat Design feedback for chat topbar Oct 7, 2023
@ibrkhalil ibrkhalil mentioned this issue Oct 7, 2023
Merged
@ibrkhalil
Copy link
Contributor Author

CleanShot_2023-10-07_at_08.20.17.mp4

This is the proposed implementation

@BalogunofAfrica
Copy link
Contributor

Duplicate of #17537

@BalogunofAfrica BalogunofAfrica marked this as a duplicate of #17537 Oct 7, 2023
@ibrkhalil
Copy link
Contributor Author

The duplication is the button overlaying the back button right?
Not the animaton issues?

@BalogunofAfrica
Copy link
Contributor

BalogunofAfrica commented Oct 7, 2023 •
edited
Loading

The duplication is the button overlaying the back button right? Not the animaton issues?

Yes. Not the animation issue.

@ibrkhalil ibrkhalil mentioned this issue Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibrkhalil ibrkhalil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New TopBar animation status-im/status-mobile
3 participants
@Parveshdhull @ibrkhalil @BalogunofAfrica