Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet: share acount bottom sheet action #17766

Closed
J-Son89 opened this issue Oct 30, 2023 · 3 comments · Fixed by #18121
Closed

Wallet: share acount bottom sheet action #17766

J-Son89 opened this issue Oct 30, 2023 · 3 comments · Fixed by #18121
Assignees
Labels
feature feature requests

Comments

@J-Son89
Copy link
Contributor

J-Son89 commented Oct 30, 2023

on this bottom sheet - https://www.figma.com/file/HKncH4wnDwZDAhc4AryK8Y/Wallet-for-Mobile?type=design&node-id=2338-508395&mode=design&t=K0hD3hXfHyjRCciH-4

and this bottom sheet there is the action "share account" ->
implement this action that follow these as per designs.

As currently understood it will use native share features however please align with design before starting

@OmarBasem
Copy link
Contributor

@J-Son89 is this still blocked?

@J-Son89
Copy link
Contributor Author

J-Son89 commented Nov 16, 2023

Yeah it's still blocked, we don't have designs for share account -

and share address we should wait for ->
#17865

because share address in wallet bottom sheets will open this on the particular address/account

@J-Son89 J-Son89 removed the blocked label Dec 1, 2023
@J-Son89
Copy link
Contributor Author

J-Son89 commented Dec 1, 2023

@OmarBasem - I believe this is not blocked.
We can however focus on share account feature and I will create a separate issue to work on share address from this bottom sheet.
As far as I understand it the share account feature will use the native ios share feature.
Please sync with design team before working on this. 👍

@J-Son89 J-Son89 changed the title Wallet: share address bottom sheet action Wallet: share acount bottom sheet action Dec 1, 2023
@OmarBasem OmarBasem self-assigned this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Development

Successfully merging a pull request may close this issue.

2 participants