Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji Picker should be able to take customization-color to have a correct background color #17807

Closed
J-Son89 opened this issue Nov 3, 2023 · 2 comments · Fixed by #17829
Closed
Assignees
Labels
feature feature requests

Comments

@J-Son89
Copy link
Contributor

J-Son89 commented Nov 3, 2023

In the designs the emoji picker has a solid background color. Update the emoji picker to match these designs

Align with the design team on the expected behaviour.

Ensure this is not breaking the emoji picker for it's other uses on different pages

@OmarBasem
Copy link
Contributor

@J-Son89 can you please clarify more what needs to be done in this issue? Any link to designs?

@J-Son89
Copy link
Contributor Author

J-Son89 commented Nov 8, 2023

@OmarBasem it's to use the watch only variant for account avatar ->
see the designs:
https://www.figma.com/file/HKncH4wnDwZDAhc4AryK8Y/Wallet-for-Mobile?type=design&node-id=2052-522184&mode=design&t=5NEcFjupudWCyMby-0
see watch-only variant
https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?type=design&node-id=24107%3A223984&mode=design&t=smsWNzemzXhDY9Er-1

so this is a 2/3 liner :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Development

Successfully merging a pull request may close this issue.

2 participants