Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ask for password when enabling biometrics during sync #17928

Closed
pavloburykh opened this issue Nov 16, 2023 · 0 comments · Fixed by #17960
Closed

Do not ask for password when enabling biometrics during sync #17928

pavloburykh opened this issue Nov 16, 2023 · 0 comments · Fixed by #17960
Assignees
Milestone

Comments

@pavloburykh
Copy link
Contributor

Context

In this PR #17627 we have introduced Enable biometrics feature during sync flow.

Due to technical issues (@cammellos can provide details) we agreed that in the first iteration of feature we will ask user for password when he enables biometrics during sync. Now we need to fix it so can enable biometrics without need to enter password in accordance to Figma

Steps:

  1. User A generates Sync QR
  2. User B scans sync QR and proceeds to Enable biometric screen
  3. User B taps Enable biometric
  4. Observe the result

Actual result: password bottom sheet appears asking user to enter password

Expected result: password should not be asked, biometric (face id/touch id) should be scanned after which user proceeds to the next screen Figma

Additional Information

  • Status version: nightly
  • Operating System: Android, iOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants