Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support URL preview for universal community URL #17954

Closed
yqrashawn opened this issue Nov 21, 2023 · 6 comments · Fixed by #18484
Closed

Support URL preview for universal community URL #17954

yqrashawn opened this issue Nov 21, 2023 · 6 comments · Fixed by #18484
Assignees

Comments

@yqrashawn
Copy link
Contributor

yqrashawn commented Nov 21, 2023

Feature Issue

User Story

As a user, 
I want to send a message with community link
So that message receivers can see basic community info without click on the URL

Description

design link https://www.figma.com/file/q3kZPl7OpbB7btFK7HG0Mr/Sharing-for-Mobile?type=design&node-id=3963-305465&mode=design&t=Ik6dByDrKbbWFmxw-4

CleanShot 2023-11-21 at 15 18 01@2x

Acceptance Criteria

  • show loading skeleton when fetching community data from waku
  • show correct community info in the preview

Notes

this relies on the internal link card component, which is not implemented yet https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?type=design&node-id=11182-147560&mode=design&t=bK9svcl7KnEyiSAQ-4
related issue on fetching community data #17770

@yqrashawn yqrashawn added feature feature requests universal-link labels Nov 21, 2023
@ibrkhalil
Copy link
Contributor

I can pick it up since I am working on a new implementation of sharing community links.

@yqrashawn
Copy link
Contributor Author

thanks @ibrkhalil
just created another issue for internal link card component #17961

@yqrashawn
Copy link
Contributor Author

since I am working on a new implementation of sharing community links.

Do you have an issue for this? Because I have this issue using the new universal link when sharing community but didn't find any sharing community feature implemented in the app

@ibrkhalil
Copy link
Contributor

since I am working on a new implementation of sharing community links.

Do you have an issue for this? Because I have this issue using the new universal link when sharing community but didn't find any sharing community feature implemented in the app

Currently I have a bugfix WIP on status-go for this #17116

@ibrkhalil
Copy link
Contributor

They have different bottom sheet options, One for inviting and one for sharing I think.
But the link preview should work for both I think.

@ibrkhalil
Copy link
Contributor

To be done, Create the community channel preview and the user link preview.
I'll do them once I have capacity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants