Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can't log in with biometrics anymore after logging out #18004

Closed
clauxx opened this issue Nov 27, 2023 · 13 comments
Closed

User can't log in with biometrics anymore after logging out #18004

clauxx opened this issue Nov 27, 2023 · 13 comments

Comments

@clauxx
Copy link
Member

clauxx commented Nov 27, 2023

Bug Report

Problem

Currently if the user logs out (through settings) from their account that has biometrics enabled, they can't use biometrics to login again nor can they enable it from the settings. The enabling from the settings would come with Settings V2, but the user should still be able to use biometrics after they log out or switch accounts. ATM all biometry information is erased during logout (auth-method & password) from the keychain.

Expected behavior

The user can log-out and log in again using biometrics. I guess the user shouldn't be prompted with the biometrics check right after logging out, but when the app is opened again biometrics should be prompted.

Actual behavior

The user can't log in with biometrics ever again after logging out

Reproduction

  1. Create account with biometrics
  2. Go to profile -> Log out -> Confirm
  3. Can only log in with password, even after closing the app and opening again

Additional Information

  • Status version: nightly
  • Operating System: Android, iOS
@yqrashawn
Copy link
Contributor

hi @clauxx, will #18258 solve this issue? Or these are separate issues?

@clauxx
Copy link
Member Author

clauxx commented Jan 9, 2024

Hi @yqrashawn, it doesn't solve it, but we decided to put a hold on it for now as we don't have a defined flow for handling biometrics during the logout phase. The issue you mentioned allows to re-enable it from the settings, which helps a bit until we have a flow.

@clauxx
Copy link
Member Author

clauxx commented Apr 5, 2024

As discussed during the crew sync (Usability and readiness for public beta), should discuss the flow with the design team and prioritize this task accordingly. If the flow would become overly complex, should be removed from the scope of this release.

During the sync we discussed two potential options:

  1. keeping the biometric data in the keychain when logging out (without triggering the automatic biometric check on the login screen)
  2. keeping the biometric data, but disabling biometrics until the user logs in again, after which the biometric check will be available again.

@clauxx clauxx added this to the 2.29.0 Alpha milestone Apr 8, 2024
@clauxx clauxx self-assigned this Apr 18, 2024
@clauxx
Copy link
Member Author

clauxx commented Apr 18, 2024

After discussing with @John-44, we decided to go with the 1st option to avoid user friction.

@cammellos
Copy link
Contributor

Removing this from 2.29 as we might not have enough time to implement cc @clauxx

@cammellos cammellos removed this from the 2.29.0 Alpha milestone Apr 30, 2024
@clauxx
Copy link
Member Author

clauxx commented Apr 30, 2024

@cammellos Yeah makes sense 👍

@mariia-skrypnyk
Copy link

mariia-skrypnyk commented Sep 6, 2024

We received a feedback https://discord.com/channels/1210237582470807632/1260272291888107520/1280732358730977291 from our user regarding switching accounts and that no biometrics is ON after it.

Here is a discussion https://discord.com/channels/1210237582470807632/1217173176086302821/1280855001488560170

So the issue is still relevant.

@ilmotta
Copy link
Contributor

ilmotta commented Oct 4, 2024

This is the new UX for improving how users login with biometrics https://www.figma.com/design/o4qG1bnFyuyFOvHQVGgeFY/Onboarding-for-Mobile?node-id=14657-26209&node-type=instance&m=dev.

@xAlisher is the UX & UI approved in that Figma link? For context, with the new keycard flows I was told only the UX was approved, not the UI, so from now on I'll try to ask for both to prevent communication issues 🙂

Once UX/UI are approved I'll create a feature issue, link to this bug issue and once the feature is implemented this bug will be nicely resolved by proxy.

@xAlisher
Copy link

xAlisher commented Oct 8, 2024

@ilmotta it's approved by @pedro-et

@ulisesmac
Copy link
Contributor

ulisesmac commented Oct 12, 2024

@xAlisher @ilmotta

Which one is exactly is the flow approved?

is it the one with the folllowing header:

Image
LINK

or the whole file?

@ilmotta ilmotta removed the bug label Oct 14, 2024
@ilmotta
Copy link
Contributor

ilmotta commented Oct 15, 2024

Correct @ulisesmac, only the top flow is approved https://www.figma.com/design/o4qG1bnFyuyFOvHQVGgeFY/Onboarding-for-Mobile?node-id=14656-26145&node-type=shape_with_text&m=dev. It's the simplest one for now. Basically, the idea is to allow the user to switch profiles by logging out, but with difference that the user is redirected to the profile selection screen instead of going to the last profile auth screen.

@ulisesmac ulisesmac self-assigned this Oct 16, 2024
@ulisesmac
Copy link
Contributor

@ilmotta I'm taking this issue but I'll start it when we plan it

@ilmotta
Copy link
Contributor

ilmotta commented Oct 21, 2024

@ilmotta I'm taking this issue but I'll start it when we plan it

Thank you @ulisesmac 👍🏼 I created a new feature issue which supersedes this one #21476. The issue will be part of an epic to simplify onboarding flows for 2.32. Based on the user feedback we got, we decided to improve the solution instead of just doing a quick bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

8 participants