Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat screen navigation view optimization leftovers #18132

Closed
10 of 17 tasks
Parveshdhull opened this issue Dec 11, 2023 · 1 comment
Closed
10 of 17 tasks

Chat screen navigation view optimization leftovers #18132

Parveshdhull opened this issue Dec 11, 2023 · 1 comment
Assignees

Comments

@Parveshdhull
Copy link
Member

Parveshdhull commented Dec 11, 2023

Regressions

  • Behavior of navigation view when keyboard is opened
  • Chat opening loading screen is incomplete (only loading skeleton is shown, other components will be implemented)
  • Issue 2
  • Issue 3
  • Issue

Also in develop, should be fixed in the scope of optimization

  • Navigation view header is too big for empty chats
  • Navigation view flickers when opening chat
  • Navigation view title is animated when chat screen is empty

Tech debt

  • Use animatedScrollHandler for flat list
  • Get rid of all reagent atoms in messages.view.cljs file (only one left)
  • Rename scroll-y
  • scroll-to-botom-fn needs improvement (probably should be an event)
  • Remove rnio library
  • Loading skeleton while hot-reloading

Design input requires

  • header-container-top-margin 48 or 52?
  • Position of pinned banner for starting animation(currently 142) (UPD: This poistion should be updated later, will depend on new-profile implementation and bio height)
  • Position of avatar for starting animation (Optimize chat screen navigation view #18055 (comment))
@Parveshdhull
Copy link
Member Author

Pending tasks moved to #18137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant