Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet: Remove all possible Mock data and feature flag code that is interacting with mock data. #18378

Closed
J-Son89 opened this issue Jan 3, 2024 · 0 comments · Fixed by #18569
Assignees
Labels
feature feature requests

Comments

@J-Son89
Copy link
Contributor

J-Son89 commented Jan 3, 2024

To speed up the development of the wallet UI mock data was initially used. Now that there is enough development in place and the pattern for integration with the rpc is stabilised we should remove all mock data.

Buy Tokens List (options menu for "Buy" on account page) - should use rpc request - GetCryptoOnRamps available in the wallet.

Some other pieces using mock data:
Bridge Page
Wallet Account -> "Bridge" Button
Use real data for tokens

Collectibles Activity,
Generate New Keypair (in the create account flow),
Address suggestions etc
should all be hidden behind a feature flag of some sort so that an end user would not see this data.
Bridging a token

Example of how to feature flag:
#18530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Development

Successfully merging a pull request may close this issue.

1 participant