Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The last collectible is shown for a moment while opening a new collectible #18750

Closed
Tracked by #18611
Parveshdhull opened this issue Feb 7, 2024 · 0 comments · Fixed by #18793
Closed
Tracked by #18611

The last collectible is shown for a moment while opening a new collectible #18750

Parveshdhull opened this issue Feb 7, 2024 · 0 comments · Fixed by #18793
Assignees
@mmilad75

Comments

@Parveshdhull
Copy link
Member

Original report: #18532 (comment)

In the case of collectible, we are seeing last collectible because we are requesting data from status-go.
In my testing, I only saw status-go calls differ in traits, etc, other than that we already have required data in db that we can use instead of waiting from status-go.

Note: Please checkout #18532 (comment) #18532 (comment) before fixing

299521223-20b4fde1-1028-49d5-b17a-9741cf42c0d0.webm
@qoqobolo qoqobolo mentioned this issue Feb 9, 2024
Closed
23 tasks
@mmilad75 mmilad75 self-assigned this Feb 12, 2024
@mmilad75 mmilad75 mentioned this issue Feb 12, 2024
Merged
mmilad75 added a commit that referenced this issue Feb 20, 2024
@mmilad75
The last collectible is shown for a moment while opening a new collec…
c7aa10c 
…tible #18750 (#18793)

* fix issue

* move navigation to the event

* move clearing to hook

* revert scroll_page

* resolve comment

* fix duplicate navigation
ibrkhalil pushed a commit that referenced this issue Feb 25, 2024
@mmilad75 @ibrkhalil
The last collectible is shown for a moment while opening a new collec…
8c2977b 
…tible #18750 (#18793)

* fix issue

* move navigation to the event

* move clearing to hook

* revert scroll_page

* resolve comment

* fix duplicate navigation
@ilmotta ilmotta removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmilad75 mmilad75

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ilmotta @Parveshdhull @mmilad75 @qoqobolo