Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts & Attachments - Reply drawer issues #19278

Closed
Francesca-G opened this issue Mar 15, 2024 · 4 comments · Fixed by #19630
Closed

Posts & Attachments - Reply drawer issues #19278

Francesca-G opened this issue Mar 15, 2024 · 4 comments · Fixed by #19630
Assignees

Comments

@Francesca-G
Copy link

Design Feedback 2.27

[Posts & Attachments] Reply drawer issues

Figma frame of the Review here

Screenshot 2024-03-15 alle 13 28 28

Reproduction

  1. Open a chat
  2. Long press on a message to open the reply drawer

Additional Information

  • Status version: nightly
  • Operating System: Android, iOS
  • Devices in the screenshots: iPhone 13
@yqrashawn
Copy link
Contributor

can't reproduce visible ident ring and unaligned contact icon

Image

@yqrashawn
Copy link
Contributor

yqrashawn commented Apr 10, 2024

before, after
the thinner one is after

reason:

  1. emojis are texts in rn/text, so height should be set with line-height
  2. padding in figma is 10, with border as 1, padding should be 9 in mobile

Image

@yqrashawn
Copy link
Contributor

  • Pressed state [comment] of the drawer action is wrong

for this one, code is using quo/menu-item but in figma it's quo/drawer-action

@yqrashawn
Copy link
Contributor

there are a lot "drawer actions" that haven't been updated to use quo/drawer-action yet, since quo/drawer-action was implemented 2 weeks ago
actually, there's no quo/drawer-action usage in current dev

  • status-im.common.mute-drawer.view, using quo/menu-items
  • quo.components.drawers.action-drawers.view, using a custom implementation
  • ...

Figma link for context drawers https://www.figma.com/file/apCsJHT8J58JXbJD2igtbd/Context-Drawers-for-Mobile?type=design&node-id=791-275811&mode=design&t=Bn4gxwEGoqobemgd-0
Figma link for drawer actions https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?type=design&node-id=1931-31188&mode=design&t=vlfhmcKKNvm3E7Vs-4

features in drawer-action but not in menu-items

  • customization color
  • toggle
  • ...

@cammellos should we create issues for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants