Inability to remove eth accounts which created by key pair generation flow or imported by seed phrase

[VolodLytvynenko]

Steps:

1. Create an account with a newly generated keypair (see flow here how to generate keypair)
2. Open current account
3. Try to remove it

Actual result:

The removing bottom sheet is not shown

bottomsheet.mp4

Expected result:

The removing bottom sheet should be shown with 'remove' and 'cancel' buttons.
https://www.figma.com/file/HKncH4wnDwZDAhc4AryK8Y/Wallet-for-Mobile?type=design&node-id=900-234771&mode=design&t=x8pd1J3e5lSLbdW3-0

ENV:

NIghtly [22 Mar 2024]

[J-Son89]

@VolodLytvynenko I remember this was discussed in the messengers. Is this still needed?
cc @ulisesmac @smohamedjavid

[VolodLytvynenko]

@VolodLytvynenko I remember this was discussed in the messengers. Is this still needed? cc @ulisesmac @smohamedjavid

hi @J-Son89 I don't remember discussing it in the messengers. We discussed it once in this PR

[J-Son89]

Ah apologies, perhaps it was a similar topic but not this. Thanks for confirming 🙏

[J-Son89]

hmm are we missing this flow?
https://www.figma.com/file/HKncH4wnDwZDAhc4AryK8Y/Wallet-for-Mobile?type=design&node-id=900-233576&mode=design&t=XKuv9zmTEoDoP9y0-4

[VolodLytvynenko]

hmm are we missing this flow? https://www.figma.com/file/HKncH4wnDwZDAhc4AryK8Y/Wallet-for-Mobile?type=design&node-id=900-233576&mode=design&t=XKuv9zmTEoDoP9y0-4

hi @J-Son89 This bottom sheet with "remove" and "cancel" buttons is shown for all accounts that were not created via generating a new keypair flow

[churik]

@VolodLytvynenko is this issue still relevant?

[VolodLytvynenko]

@VolodLytvynenko is this issue still relevant?

@churik still relevant

[ulisesmac]

Hi @saledjenic

The accounts generated when we recover a seed phrase are type seed, currently we only remove the accounts with type generated.

Should we use the same mechanism to remove an account of type seed.

Thank you

[smohamedjavid]

The same RPC method accounts_deleteAccount should work for all addresses irrespective of key pair type, including watch-only addresses 👍

[saledjenic]

The same RPC method accounts_deleteAccount should work for all addresses irrespective of key pair type, including watch-only addresses 👍

Correct.

[ulisesmac]

Thank you @smohamedjavid @saledjenic

I'll be taking this issue