Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing validation for minimum character requirement in nickname field #19406

Closed
VolodLytvynenko opened this issue Mar 26, 2024 · 0 comments · Fixed by #19517
Closed

Missing validation for minimum character requirement in nickname field #19406

VolodLytvynenko opened this issue Mar 26, 2024 · 0 comments · Fixed by #19517
Assignees
@mohsen-ghafouri
Milestone
2.29.0 Beta

Comments

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Mar 26, 2024 •
edited
Loading

Steps:

  1. UserA on the profile page of UserB
  2. Tap three dots -> tap 'add nickname'
  3. Enter less than 5 chars into nickname field

Actual result:

No validation is applied
image

Expected result:

'Minimum 5 characters' validation message should be shown

reference to https://discord.com/channels/624634427930312714/1026813762910564393/1219632940431048724
@VolodLytvynenko VolodLytvynenko added this to the 2.29.0 Alpha milestone Mar 26, 2024
@mohsen-ghafouri mohsen-ghafouri self-assigned this Apr 2, 2024
mohsen-ghafouri added a commit that referenced this issue Apr 4, 2024
@mohsen-ghafouri
[#19406] fix: add min char validation for nickname
d5481e4
@mohsen-ghafouri mohsen-ghafouri mentioned this issue Apr 4, 2024
Merged
mohsen-ghafouri added a commit that referenced this issue Apr 4, 2024
@mohsen-ghafouri
[#19406] fix: add min char validation for nickname
346651e
mohsen-ghafouri added a commit that referenced this issue Apr 4, 2024
@mohsen-ghafouri
[#19406] fix: disable button while typing
db519a8
mohsen-ghafouri added a commit that referenced this issue Apr 5, 2024
@mohsen-ghafouri
[#19406] fix: add min char validation for nickname
b715eda
mohsen-ghafouri added a commit that referenced this issue Apr 5, 2024
@mohsen-ghafouri
[#19406] fix: disable button while typing
d884324
mohsen-ghafouri added a commit that referenced this issue Apr 5, 2024
@mohsen-ghafouri
[#19406] fix: add min char validation for nickname (#19517)
aead730
@ilmotta ilmotta removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohsen-ghafouri mohsen-ghafouri

Labels
None yet
Projects
👨‍🎤🪄 Voguish Magicians [mobile] (Usability and readiness for public beta)
Status: Done
Milestone
2.29.0 Beta
Development

Successfully merging a pull request may close this issue.

[#19406] fix: add min char validation for nickname status-im/status-mobile
4 participants
@ilmotta @cammellos @VolodLytvynenko @mohsen-ghafouri