Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect derivation path for newly generated keypair accounts and theirs derived acccounts #19472

Closed
Tracked by #19466
VolodLytvynenko opened this issue Apr 1, 2024 · 4 comments · Fixed by #19531
Closed
Tracked by #19466

Comments

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Apr 1, 2024

Steps:

  1. Create an account with a newly generated keypair (see flow here how to generate keypair)
  2. Check the derivation path for newly created account

Actual result:

The number is incremented at the end for the Derivation path for keypair account and = m/44/60'/0'/0/<incremented account number>

Expected result:

The derivation path for master (keypair) accounts should not have an incremented number at the end; it should be m/44/60'/0'/0/0. Only accounts that are derived from the master (keypair) accounts should have an incremented path.

For example, if a user has two generated keypairs and two additional accounts derived for each keypair account then derivation path hierarchy should looks so:

  • Keypair account first: m/44/60'/0'/0/0
    • Test account 2 (derived from Keypair account first): m/44/60'/0'/0/1
    • Test account 3 (derived from Keypair account first): m/44/60'/0'/0/2
  • Keypair account second: m/44/60'/0'/0/0
    • Test account 4 (derived from Keypair account second): m/44/60'/0'/0/1
    • Test account 5 (derived from Keypair account second): m/44/60'/0'/0/2

discussed in https://discord.com/channels/1210237582470807632/1217175448828514344/1224605345461047326
in the same way it works for Desktop.

@ulisesmac
Copy link
Contributor

ulisesmac commented Apr 9, 2024

@J-Son89
Copy link
Contributor

J-Son89 commented May 13, 2024

@ulisesmac - since derivation path flows have been descoped can you unassign this issue and block it for now?
Or what's the status of this issue? 🤔

@ulisesmac
Copy link
Contributor

@J-Son89

We must generate a default derivation path for a new derived account in wallet. This issue isn't about the derivation path flow (where you can set a custom one) it's about adding a new account in wallet.

Currently, we are stuck, seems Android is not creating a keystore file so maybe there's a bug on Status go side, this issue has become very complex.

BTW, @OmarBasem did you replicate the issue we had for new keypairs? If you did, it's time to align with Sale and check what's the problem in Status go.

@OmarBasem
Copy link
Contributor

Hey @ulisesmac,
What I had in mind did not work also.

maybe there's a bug on Status go side

I think it works properly on Desktop (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

5 participants