-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The app randomly gets stuck on the login page. #19484
Comments
Might be a relevant line
|
type=1400 errors turned out to be SELinux related, Investigating |
An issue with SELinux with targetSdkVersions higher than 29? |
May I have some more information about the device tested? Like Model, Android version and if it was rooted or not |
Hey @ibrkhalil
Additionally, it is reproducible on different devices for the QA team |
Logs would be really helpful if possible for these devices. |
As @VolodLytvynenko said that the issue happens on iOS then it's highly unlikely to be a SELinux error. |
What do we think about adding a timeout to the login screen? That way if the login native function fails for any reason we'll have a way to unfreeze the screen (and maybe show an error). Thoughts? |
@VolodLytvynenko : These logs don't have any debug messages. You can find this in profile > settings > advanced > log level |
Hi @seanstrom @ibrkhalil @VolodLytvynenko : To me it looks like the media server was also not running when the attempt to login was made. Hence we do not see the account's profile picture. |
Yeah I agree, we should try debugging what happens on the login screen. I can try seeing what happens if i disable the media server before logging in, that might help confirm what’s happening. I also tried debugging what happens if the native module function would fail, and it seems that would also freeze the login screen. I think this can happen because when we login we send a request to login, wait for a separate event to be received, and then login the app. If that separate event is never received then we’ll be stuck at the login screen I think. |
Ah we need not do that actually. Media server not running could be the symptom that might need fixing and might indicate something that broke right before that stage. If we fix that we may fix this issue.
This part of login could definitely be made more robust like you said. Regarding the root cause, we could decorate the logout part which starts a media server in status-go with more logs to see if it malfunctions -> https://github.com/status-im/status-go/blob/e2a4a2289618910a062b8d51105acb58449180bc/api/geth_backend.go#L2202-L2239 |
my guess, might be relate to this waku-org/go-waku#1085 , if logout stuck, login will stuck |
hey. @ibrkhalil @siddarthkay apologies for initially providing only 'info' level logs. Although this issue doesn't occur frequently, I just encountered it again with 'debug' log level. hope these logs might help to catch what going on Device:Pixel 7a, Android 14 Logs: |
my previous guess seems proberbly right since i can't see "status node stopped" in geth.log for the second logging out🤪. |
Nice! 🙌 |
it's possible to send a restart command, however, the deadlock will still be there. I think we can improve the usage of lock in status-go side, e.g. add timeout for holding a lock and report possible deadlock? cc @cammellos |
@qfrank was this fixed by your two commits? |
I think so, but not sure if @VolodLytvynenko still faced this issue after these 2 commits. @cammellos
|
I left the opportunity to @VolodLytvynenko to close this issue. 🙂 |
@cammellos @qfrank I haven't encountered this issue anymore. I will reopen it if it still reproduces. For now, let's close it. |
The current issue occurs very rarely, and there are no exact steps on how to reproduce it. I hope the logs might help
Steps:
Actual result:
The app randomly gets stuck on the login page.
android.mp4
Expected result:
The user is login
Logs:
logs (1).txt
The text was updated successfully, but these errors were encountered: