Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not aligned 'Share' icon, no shadow on app top bar, contact name is not in bold - on QR code screens #3196

Closed
Serhy opened this issue Feb 2, 2018 · 3 comments

Comments

@Serhy
Copy link
Contributor

Serhy commented Feb 2, 2018

Type: Bug

Summary: There are UI issues on both public key and address QR code screens:

  1. On iOS and Android there is a black status bar (moved into separate issue Black status bar on QR code screens #3227)
  2. On Android only there is no shadow at the bottom line of app top bar
  3. On iOS only the 'Share' icon should be aligned to the right to 12px
  4. On iOS only - the contact name is not in the bold font style

iOS screen:
ios

Android screen:
andoro

Expected behavior

Aligned Share icon to the right with 12 px, shadow at the bottom line of app top bar on Android, bold font of contact name on iOS - on the QR code screens

Actual behavior

Not aligned Share icon to the right on iOS, no shadow at the bottom line of app top bar on Android, no bold font of the contact name on iOS - on the QR code screens

Reproduction

  • Open Status and create account
  • Navigate to Profile -> Share my contact code screen (Note: this is for public key QR screen)
  • Navigate to Home -> Start new chat -> 1-1 chat with Jarrad -> Profile screen at top-right -> Show QR code for Address

Additional Information

  • Status version: Develop 0.9.11d626 (iOS) / 03e625 (Android)
  • Operating System: Android 7.0 (Samsung J7 real device), iOS 11.2.2 (iPhoneX)
@Serhy Serhy added the bug label Feb 2, 2018
@jeluard
Copy link
Contributor

jeluard commented Feb 5, 2018

@Serhy Could we split status-bar issue to a separate ticket? Those will require some more global thinking.

@Serhy Serhy changed the title Black status bar and not aligned 'Share' icon on QR code screens Not aligned 'Share' icon, no shadow on app top bar, contact name is not in bold - on QR code screens Feb 6, 2018
@Serhy
Copy link
Contributor Author

Serhy commented Feb 6, 2018

@jeluard Done. #3227 created as separate for status-bar issue

@Serhy
Copy link
Contributor Author

Serhy commented Mar 20, 2018

#3247 fixed it. Closing the issue.

@Serhy Serhy closed this as completed Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants