Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat header stops displaying after switching between public and 1-1 chats #4249

Closed
churik opened this issue May 14, 2018 · 10 comments
Closed
Assignees

Comments

@churik
Copy link
Member

churik commented May 14, 2018

User Story

As a user, I want always to see chat header.

Description

Type: Bug
Summary: switching between public and 1-1 chats leads to chat header disappearing.

Expected behavior

chat header (name) is always visible

Actual behavior

no visible chat header
ghgh

Reproduction

  • Open StatusIm
  • Create 1-1 (chat A) and join to public chat (chat B)
  • Switch between chat A and chat B 2+ times

Additional Information

  • Status version: StatusIm desktop (version 2018-05-07)
  • Operating System: MacOS High Sierra 10.13.4, Ubuntu 18.04
  • Video: http://take.ms/h3Vwh
@churik churik removed the macOS label May 14, 2018
@rcullito rcullito self-assigned this May 31, 2018
@EugeOrtiz
Copy link

Designs of how headers look like can be found here (Zeplin):

  • 1:1 chat, unknown person: zpl.io/aRqj4dv
  • 1:1 chat with a contact: zpl.io/am6gW4v
  • Public chat: zpl.io/bAv8OjB

@rcullito
Copy link
Contributor

rcullito commented Jun 8, 2018

these are great, thanks @EugeOrtiz. 👌 timing

@maxhora
Copy link
Contributor

maxhora commented Jul 5, 2018

@churik this Issue should be re-validated against latest manual desktop build. Hopefully, shouldn't appear any more since #4578 is merged already.

@churik
Copy link
Member Author

churik commented Jul 5, 2018

Still reproducible on desktop, build 11
Video: header

@maxhora
Copy link
Contributor

maxhora commented Jul 5, 2018

@rcullito @churik chat headers visibility issue visually looks like the corresponding text label doesn't get the width correctly and brake one line test into multi-line. It seems it somehow depends on the length of available chats titles.

@churik
Copy link
Member Author

churik commented Jul 9, 2018

@Maxris so the problem is not in react-native side?

@maxhora
Copy link
Contributor

maxhora commented Jul 9, 2018

@churik I haven't yet checked exactly this issue, but it seems that after recent change in react-native-desktop headers started working better/differently at least for me :)

@churik
Copy link
Member Author

churik commented Jul 9, 2018

It is still trimmed to shortest channel name in the list (for example if you are switching between #tchu channel and 'Testing IOS recover' 1-1 chat, chat header for 1-1 becomes 'Testin')
reco

Build: build_15
Video: header_build_15

@vkjr vkjr self-assigned this Aug 9, 2018
@vkjr
Copy link
Contributor

vkjr commented Aug 9, 2018

Will take this while @rcullito is unavailable

@churik
Copy link
Member Author

churik commented Aug 15, 2018

Closed after merging status-im/react-native-desktop-qt#314

@churik churik closed this as completed Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants