Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stable and reliable messaging between desktop and mobile #4730

Closed
asemiankevich opened this issue Jun 12, 2018 · 7 comments
Closed

Make stable and reliable messaging between desktop and mobile #4730

asemiankevich opened this issue Jun 12, 2018 · 7 comments

Comments

@asemiankevich
Copy link
Contributor

asemiankevich commented Jun 12, 2018

User Story

As a user, I want to have stable messaging between desktop and mobile apps.

Description

Type: Bug

Summary: messaging does not work when sending something from desktop to mobile. Talked to @Maxris and @vkjr and here is a possible solution to make it working:

  1. Merge new version of react-native into react-native-desktop (moved to Merge latest RN (0.55) into RN-desktop #4743)
  2. Merge desktop branch into develop.
  3. Anything what was added recently and requires some special porting to desktop ( how about db encryption )
  4. merge latest status-go changes into status-go desktop branch. (moved to Merge latest status-go into status-go desktop and merge back desktop changes into main status-go development branch #4841)

Expected behavior

Messaging is stable and reliable between desktop and mobile

@vkjr
Copy link
Contributor

vkjr commented Jul 25, 2018

@chu, @asemiankevich, PR #5284 will be the last one about merging desktop and develop branch. I'm wondering, how we will test the stable and reliable messaging after it is merged?
Do we have a dedicated tests for that?

@asemiankevich
Copy link
Contributor Author

@vkjr we have message reliability tests for mobile app (automated). Nothing is automated for desktop yet. The only solution I see for now is testing this manually for the desktop. Do you have any suggestions in mind?

@vkjr
Copy link
Contributor

vkjr commented Jul 25, 2018

@asemiankevich, not really :( Was asking mostly because I'm assigned to this one. Maybe after merge I'll remove the assignment and change description since merge on itself doesn't guarantee reliable messaging.

@vkjr
Copy link
Contributor

vkjr commented Jul 27, 2018

Merging to develop finished. So this issue could be tested to check if messaging is reliable.

@vkjr vkjr removed their assignment Jul 27, 2018
@maxhora
Copy link
Contributor

maxhora commented Jul 27, 2018

Please aware about #5317 potential issue.

@vkjr
Copy link
Contributor

vkjr commented Jul 27, 2018

@Maxris, good point, thanks!

@churik
Copy link
Member

churik commented Aug 10, 2018

Fixed since rebased to develop branch

@churik churik closed this as completed Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants