Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test status-go bip32 fix on status-react side #5495

Closed
goranjovic opened this issue Aug 14, 2018 · 5 comments
Closed

test status-go bip32 fix on status-react side #5495

goranjovic opened this issue Aug 14, 2018 · 5 comments
Assignees

Comments

@goranjovic
Copy link
Contributor

goranjovic commented Aug 14, 2018

Testing status-go PR fix child keys derivation adding bytes padding).

status-react builds with status-go artifact from that PR

Branch: status-im:test/bip32-fix
Android: https://i.diawi.com/FNzR7h
iOS: https://i.diawi.com/EVsTS8

Problem

The current implementation of status-go derives wrong keys/addresses in certain conditions, more info are in the original PR status-im/status-go#1139

Test 1

With the mnemonic radar blur cabbage chef fix engine embark joy scheme fiction master release, the current status-go derives the address 0xc154991dd4c2ddb5c089cf2e0fd23f5f1e41ba72.

With these changes the correct address should be derived: 0xaC39b311DCEb2A4b2f5d8461c1cdaF756F4F7Ae9.

Test 2

Old mnemonic phrases should continue to derive the same addresses.

@asemiankevich
Copy link
Contributor

  1. able to recover 0xaC39b311DCEb2A4b2f5d8461c1cdaF756F4F7Ae9 with radar blur cabbage chef fix engine embark joy scheme fiction master release

  2. able to recover my personal wallet

  3. lets wait for e2e run

@asemiankevich
Copy link
Contributor

@goranjovic @pilu @adambabik please merge it

@asemiankevich
Copy link
Contributor

asemiankevich commented Aug 16, 2018

here is the thread for some context https://status-im.slack.com/archives/CA7R1RK0C/p1534182376000174

@ghost
Copy link

ghost commented Nov 14, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants