Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL's scannable with Status QR code scanner #5776

Closed
Graeme-Code opened this issue Sep 6, 2018 · 21 comments
Closed

URL's scannable with Status QR code scanner #5776

Graeme-Code opened this issue Sep 6, 2018 · 21 comments

Comments

@Graeme-Code
Copy link

Graeme-Code commented Sep 6, 2018

User Story

As a user,
when I scan a QR code which represents a URL I should offered the choice to open with status or web browser,
so that I may access the webpage.

Description

Type: Feature

Summary:

Currently, the QR code scanner handles universal links, user names and ethereum accounts. This feature proposes expanding the QR code scanner to handle URL's which are not preceded with a universal link.

The reason is currently accessing a Dapp by scanning a QR code is only possible via universal link. This narrows the QR code scanners ability and puts extra load on dapp developers to either print 2 QR codes (one just a URL and one a status universal link).

Expected behavior

The expected behavior is that a URL which is not a Dapp universal link is handled the same way a URL is handled when tapped on by a user in chat.

Scan QR code -> pop up requesting to open in status browser or web browser.

Actual behavior

Currently, scan QR code returns an error notifying the user the QR code scanner will only open universal links, ENS names or Ethereum account addresses.

Solution

Summary:

The solution is for QR code scanner to handle URL's in the same as when a link is tapped in chat.
img!UNITO-UNDERSCORE!0018
img!UNITO-UNDERSCORE!0019

img!UNITO-UNDERSCORE!0003

![](/images/branding/product/ico/googleg_lodp.ico)
[Google](https://www.google.com/)
Search the world's information, including webpages, images, videos and more. Google has many special features to help you find exactly what you're looking for.
@chadyj
Copy link
Contributor

chadyj commented Nov 28, 2018

Fixed?

@status-github-bot
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mandrigin
Copy link
Contributor

let's do a bounty out of it!

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Mar 18, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 months ago.
Please review their action plans below:

1) krisc has been approved to start work.

After working on this QR-related bounty (ui.screens.add-new.models) I have become familiarized with the qr-scanner module. A new branch can be added in ui.screens.add-new.models to handle this new case.

Learn more on the Gitcoin Issue Details page.

@krisc
Copy link

krisc commented Mar 20, 2019

@StatusSceptre can I get approved for this? I actually already found a quick fix. Just have to clean up the code

@krisc
Copy link

krisc commented Apr 1, 2019

I think whoever is behind @StatusSceptre has changed? Just trying to bump this. Can I get approved?

@StatusSceptre
Copy link
Member

Apologies, working through the flow of doing this on a regular cadence. Will try and be more responsive with approvals.

@gitcoinbot
Copy link

@krisc Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@krisc Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@krisc
Copy link

krisc commented Apr 9, 2019

pretty much done here #7880

Just fixing an error check.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 80.0 DAI (80.0 USD @ $1.0/DAI) has been submitted by:

  1. @krisc

@StatusSceptre please take a look at the submitted work:


@StatusSceptre
Copy link
Member

noted, waiting for merge.

@StatusSceptre
Copy link
Member

@mandrigin can I get an update on this? It's been a while.

@krisc
Copy link

krisc commented May 3, 2019

There are still some issues with the PR. I'll have more time to resolve this after the weekend.

@StatusSceptre
Copy link
Member

@krisc any update here?

@krisc
Copy link

krisc commented May 10, 2019

@StatusSceptre I'm preparing a new PR right now for another issue that might solve this one too.

@hesterbruikman
Copy link
Contributor

Hi @krisc has your PR solved this issue or is it still open?

@krisc
Copy link

krisc commented Jun 11, 2019

hit a roadblock on the other PR, and it may be unrelated after all. As mentioned here #7880, I was having issues with nix and will be submitting a brand new PR for this issue.

hit a minor roadblock there due to #8366, but I'll try to submit a new PR for this issue at some point today.

@StatusSceptre
Copy link
Member

URL scanning fixed in #10729
Support for universal QR code scanner will be reintroduced in #10764

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @krisc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants