-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL's scannable with Status QR code scanner #5776
Comments
Fixed? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
let's do a bounty out of it! |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to it.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 3 months ago. 1) krisc has been approved to start work. After working on this QR-related bounty (ui.screens.add-new.models) I have become familiarized with the qr-scanner module. A new branch can be added in Learn more on the Gitcoin Issue Details page. |
@StatusSceptre can I get approved for this? I actually already found a quick fix. Just have to clean up the code |
I think whoever is behind @StatusSceptre has changed? Just trying to bump this. Can I get approved? |
Apologies, working through the flow of doing this on a regular cadence. Will try and be more responsive with approvals. |
@krisc Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
1 similar comment
@krisc Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
pretty much done here #7880 Just fixing an error check. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 80.0 DAI (80.0 USD @ $1.0/DAI) has been submitted by: @StatusSceptre please take a look at the submitted work:
|
noted, waiting for merge. |
@mandrigin can I get an update on this? It's been a while. |
There are still some issues with the PR. I'll have more time to resolve this after the weekend. |
@krisc any update here? |
@StatusSceptre I'm preparing a new PR right now for another issue that might solve this one too. |
Hi @krisc has your PR solved this issue or is it still open? |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @krisc.
|
User Story
As a user,
when I scan a QR code which represents a URL I should offered the choice to open with status or web browser,
so that I may access the webpage.
Description
Type: Feature
Summary:
Currently, the QR code scanner handles universal links, user names and ethereum accounts. This feature proposes expanding the QR code scanner to handle URL's which are not preceded with a universal link.
The reason is currently accessing a Dapp by scanning a QR code is only possible via universal link. This narrows the QR code scanners ability and puts extra load on dapp developers to either print 2 QR codes (one just a URL and one a status universal link).
Expected behavior
The expected behavior is that a URL which is not a Dapp universal link is handled the same way a URL is handled when tapped on by a user in chat.
Scan QR code -> pop up requesting to open in status browser or web browser.
Actual behavior
Currently, scan QR code returns an error notifying the user the QR code scanner will only open universal links, ENS names or Ethereum account addresses.
Solution
Summary:
The solution is for QR code scanner to handle URL's in the same as when a link is tapped in chat.
The text was updated successfully, but these errors were encountered: