Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Ensure failed token transactions are shown as such #8153

Closed
yenda opened this issue May 8, 2019 · 2 comments
Closed

[Wallet] Ensure failed token transactions are shown as such #8153

yenda opened this issue May 8, 2019 · 2 comments
Labels
feature feature requests

Comments

@yenda
Copy link
Contributor

yenda commented May 8, 2019

Problem

Token transactions can fail when the user doesn't have enough tokens at the moment the transaction is included in the chain. This isn't shown properly especially in the transaction received messages in chat

Implementation

  • if a transaction has 0 eth and some data, we show it as a contract call and try to decode the data in a human readable form
  • if a transaction has 0 eth, some data but no log we can assume that the underlying contract execution failed. for erc20 tokens that would usually mean you didn’t have enough tokens or you didn’t pay enough gas

Acceptance Criteria

  • an ERC20 token transaction for which the user didn't had enough funds is shown as failed token transaction in the transaction list and chat messages
@yenda yenda added the wallet label May 8, 2019
@yenda yenda self-assigned this May 8, 2019
@yenda yenda mentioned this issue May 8, 2019
12 tasks
@annadanchenko annadanchenko added the feature feature requests label May 9, 2019
@flexsurfer flexsurfer changed the title Ensure failed token transactions are shown as such [Wallet] Ensure failed token transactions are shown as such May 23, 2019
@flexsurfer
Copy link
Member

@yenda any updates for this issue?

@flexsurfer
Copy link
Member

@yenda is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Projects
None yet
Development

No branches or pull requests

5 participants