Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newBlockFilter signal from status-go #8159

Closed
yenda opened this issue May 8, 2019 · 0 comments · Fixed by #8158
Closed

Use newBlockFilter signal from status-go #8159

yenda opened this issue May 8, 2019 · 0 comments · Fixed by #8158
Labels
feature feature requests

Comments

@yenda
Copy link
Contributor

yenda commented May 8, 2019

Problem

Currently transactions confirmations is updated as part of the transaction fetching loop so it is delayed and based on information provided by a third party

Rationale

While trivial, this issue will be done first as part of wallet improvement because it is the simplest use case for the newly added status-go subscriptions to eth filters

Implementation

  • Use status-go eth_newBlockFilter signal to update current block number
  • base number of confirmations in transaction details on the current block number

Acceptance Criteria

  • number of confirmations in transaction details is updated within 2 seconds of a new block mined on chain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants