Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload profile picture with ENS #9966

Closed
rachelhamlin opened this issue Feb 3, 2020 · 1 comment
Closed

Upload profile picture with ENS #9966

rachelhamlin opened this issue Feb 3, 2020 · 1 comment
Labels
feature feature requests

Comments

@rachelhamlin
Copy link
Contributor

rachelhamlin commented Feb 3, 2020

Feature Issue

We're converting profile photos into a feature of ENS. The primary reason is that profile photos were confusing before—only contacts could see them. In v1, contacts have no other privileges or special relationship.

Photos simply make more sense as part of a user's ENS identity.

However, the more value we build around ENS, the more important it becomes that we allow users the option to pay for their name privately, or at least with a wallet of their choosing. We are prioritizing the option to remove your name from your chat key for the same release, to offer a measure of control over a user's wallet exposure.

User Story

As a user, I want to upload a custom photo to my ENS profile so that I can be identified by it in chat.

Description

These are the options designed by @errorists:

  1. User can upload a photo during registration—this is optimal, as the user then pays one network fee in the course of registration.
  2. User can upload or change photo at any later point. This requires another Tx and gas.
  3. User can remove a photo they've uploaded.

Registration flow
Change or remove photo (entry point = user profile photo within ENS section)

Acceptance Criteria

  • User can add/change/cancel adding photo during registration
  • User can change or remove photo once added, or add one if there is not one
  • User can position, crop and preferably pinch to scale image
  • Image requirements? File type?
  • IPFS storage
@3esmit
Copy link
Member

3esmit commented Feb 24, 2020

We could use contenthash to set a JSON typed data into the user, where one of the fields could be profilepic https://github.com/ensdomains/resolvers/blob/master/contracts/profiles/ContentHashResolver.sol

@StatusWrike StatusWrike changed the title Upload profile picture with ENS Upload profile picture with ENS Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Projects
None yet
Development

No branches or pull requests

5 participants