Update UI for group chat creation and profile #10099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (60)
|
Ferossgp
changed the title
Ferossgp
force-pushed
the
group-chat-creation-ui
branch
2 times, most recently
from
6deb621 to
e9d2a27
Compare
|
some mistakes
• same as with other chats it should use modal presentation, 'X' to close
• the button to confirm chat creation should be without the chevron and use the '500' font weight |
|
Profiles need some additional work to be complete, • as an admin, no way to edit the chat name
|
cammellos
force-pushed
the
group-chat-creation-ui
branch
2 times, most recently
from
306034d to
f6e249f
Compare
12 tasks
cammellos
force-pushed
the
group-chat-creation-ui
branch
from
f6e249f to
1e306f7
Compare
cammellos
force-pushed
the
group-chat-creation-ui
branch
2 times, most recently
from
a7f4f9e to
56c24d1
Compare
Ferossgp
force-pushed
the
group-chat-creation-ui
branch
2 times, most recently
from
ea76e61 to
b3e88da
Compare
|
the first screen of creating a group chat where you select members:
screen where you name the group
I thought we killed the 'Delete chat' buttons? what does it do and why it's available for both admins and members alike? Edit chats screen
after bringing the app from background, I'm stuck on a spinner centred in the chats screen, all other views work ok. |
Delete chat makes the member (or admin) leave the chat & delete locally |
|
Yea this doesn't make sense to me xD I'd only leave 'Leave chat' with the behaviour of deleting so |
|
edit: managed to reproduce it after a clean re-install |
Ferossgp
force-pushed
the
group-chat-creation-ui
branch
from
b3e88da to
f92c603
Compare
|
@cammellos can you please have a look at Issue 5? |
cammellos
force-pushed
the
group-chat-creation-ui
branch
from
2ffa146 to
37b2c58
Compare
|
All issues from #10099 (comment) are fixed, I'm starting refactoring e2e tests for group chats. |
|
@Ferossgp Also I can't scroll to the end of the list with opened keyboard if I have 10 members - last 4 are overlapped with keyboard. |
Ferossgp
force-pushed
the
group-chat-creation-ui
branch
from
37b2c58 to
8255faa
Compare
|
@churik fixed the list |
Ferossgp
force-pushed
the
group-chat-creation-ui
branch
2 times, most recently
from
2e02743 to
0785d85
Compare
95% of end-end tests have passedFailed tests (8)Click to expand
Passed tests (143)Click to expand
|
|
tests results are here: #10315 |
Add search for contacts Add format name inside contact Add back button on create group Fix current contact name and alias fixup Update UI for group chat profile Fix tests Ui clean up fix change group chat name Add leave group chat option Hide options if user has left the chat Use modal for all required chat screens Add dark mode to group chats Fix offset 10 pt off screen on presentation modals Wrap keyboard avoiding view with safe area offset Keep only leave chat Fix search input focus Make edit name active when title not changed Fix lint review cleanup QA review Fix group chat inviter name Fit flat list into container Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
Ferossgp
force-pushed
the
group-chat-creation-ui
branch
from
0785d85 to
461b6cd
Compare
This was referenced Apr 14, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.figma.com/file/aS1ct66VQ6V0cio7vSqS8UoG/Chat?node-id=8136%3A270