chore: add composer button to quo2 and use in app #16902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (13)
|
flexsurfer
approved these changes
Aug 7, 2023
J-Son89
force-pushed
the
jc/composer-buttons
branch
from
c90c080 to
6a15d86
Compare
ajayesivan
reviewed
Aug 7, 2023
Whoops, good spot @ajayesivan !! |
J-Son89
force-pushed
the
jc/composer-buttons
branch
from
6a15d86 to
ae2cf6f
Compare
alwx
approved these changes
Aug 8, 2023
|
@J-Son89 thanx for the PR. Please take a look at the issues ISSUE 1 Record/mic button still has wrong colorActual result:
|
ISSUE 2 Alert is missing when tapping stickers buttonActual result: telegram-cloud-document-2-5373339562896535041.mp4Expected result: telegram-cloud-document-2-5373339562896535043.mp4 |
|
Thanks @pavloburykh, will address! :) |
J-Son89
force-pushed
the
jc/composer-buttons
branch
from
ae2cf6f to
e4faa68
Compare
J-Son89
force-pushed
the
jc/composer-buttons
branch
from
e4faa68 to
2bc039e
Compare
|
@pavloburykh both issues should be addressed now 👍 |
Thanx @J-Son89 ! LGTM! @Francesca-G please review from your side. |
J-Son89
force-pushed
the
jc/composer-buttons
branch
from
2bc039e to
4497a9f
Compare
andresceballosm
pushed a commit
to andresceballosm/status-mobile
that referenced
this pull request
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #16844
This pr adds the composer buttons: https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?type=design&node-id=25780-229859&mode=design&t=8CjTcYy1jVp0FHLe-4
and adds them to quo2 preview screens in Buttons -> composer buttons.
It also uses them on the composer screen:
https://www.figma.com/file/wA8Epdki2OWa8Vr067PCNQ/Composer-for-Mobile?type=design&node-id=3253-535124&mode=design&t=EYHMPxRHOmb8Ofg1-4
Design and QA test 🙏
light mode & dark mode