Raise clj-kondo linter levels #17289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilmotta
requested review from
flexsurfer,
yqrashawn,
J-Son89 and
mohsen-ghafouri
J-Son89
approved these changes
Sep 14, 2023
Jenkins Builds
|
ilmotta
commented
Sep 14, 2023
| event-js | ||
| true) | ||
| "wallet" (ethereum.subscriptions/new-wallet-event cofx | ||
| "node.login" (profile.login/login-node-signal cofx (transforms/js->clj event-js)) |
There was a problem hiding this comment.
FYI: I had to reformat this file because somehow it got merged into develop incorrectly.
|
FYI: @churik, as an exception, I'm going to merge this PR without running e2e because it only fixes some linter rules (which are impacting other devs). As you know, the checks are all static and have no runtime/behavioral impact. |
|
Thank you for tagging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently, we changed clj-kondo default
fail-levelfromwarningtoerror, but we missed the fact that we needed to raise the default level for all linters set towarning.This PR fixes this problem at once.
Areas that may be impacted
None.
status: ready