Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unread badges behavior on Jump-to screen #17363

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix unread badges behavior on Jump-to screen #17363

merged 1 commit into from
Sep 21, 2023

Conversation

Parveshdhull
Copy link
Member

fixes #17349

status: ready

@Parveshdhull Parveshdhull self-assigned this Sep 20, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Sep 20, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4f7a6c8 #1 2023-09-20 15:40:46 ~6 min ios 📱ipa 📲
✔️ 4f7a6c8 #1 2023-09-20 15:41:30 ~7 min android 🤖apk 📲
✔️ 4f7a6c8 #1 2023-09-20 15:41:54 ~7 min android-e2e 🤖apk 📲
✔️ 4f7a6c8 #1 2023-09-20 15:43:39 ~9 min tests 📄log
✔️ 2913341 #2 2023-09-20 16:29:04 ~5 min android-e2e 🤖apk 📲
✔️ 2913341 #2 2023-09-20 16:29:29 ~6 min android 🤖apk 📲
✔️ 2913341 #2 2023-09-20 16:29:49 ~6 min ios 📱ipa 📲
✔️ 2913341 #2 2023-09-20 16:32:46 ~9 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 038146e #3 2023-09-21 08:45:12 ~5 min android 🤖apk 📲
✔️ 038146e #3 2023-09-21 08:46:06 ~6 min ios 📱ipa 📲
✔️ 038146e #3 2023-09-21 08:48:33 ~9 min android-e2e 🤖apk 📲
✔️ 038146e #3 2023-09-21 08:48:57 ~9 min tests 📄log
✔️ d327c7e #4 2023-09-21 12:03:48 ~6 min android-e2e 🤖apk 📲
✔️ d327c7e #4 2023-09-21 12:03:55 ~6 min android 🤖apk 📲
✔️ d327c7e #4 2023-09-21 12:04:03 ~6 min ios 📱ipa 📲
✔️ d327c7e #4 2023-09-21 12:06:51 ~9 min tests 📄log

@Parveshdhull Parveshdhull force-pushed the fix/unread-shell-behaviour branch from 4f7a6c8 to 2913341 Compare September 20, 2023 16:23
@status-im-auto
Copy link
Member

77% of end-end tests have passed

Total executed tests: 43
Failed tests: 10
Passed tests: 33

IDs of failed tests: 702784,702732,703133,702948,702894,702783,703503,702786,702731,702808

Failed tests (10)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: ChatMessageInput element not found
    Device 2: Looking for a message by text: #cats 

    critical/test_public_chat_browsing.py:1265: in test_community_hashtag_links_to_community_channels
    self.channel_2.chat_element_by_text(message_with_hashtag).click_on_link_inside_message_body()
../views/chat_view.py:188: in click_on_link_inside_message_body
    self.message_body.wait_for_visibility_of_element(30)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]` is not found on the screen after wait_for_visibility_of_element; 
 RemoteDisconnected



    Device sessions

    2. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member gets push notification with the mention and tap it
    Device 2: Getting PN by 'user_2' 

    critical/test_public_chat_browsing.py:1149: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

    [[Issue with username in PN, issue #6 in 15500]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    # STEP: Check that can login with different user
    Device 1: Find Button by accessibility id: show-profiles 

    critical/test_public_chat_browsing.py:510: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.sign_in.show_profiles_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `show-profiles` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] https://github.com//issues/17175]]

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784

    ## Sign in (password:qwerty1234, keycard:False)
    Device 2: Find EditBox by accessibility id: password-input 

    critical/chats/test_1_1_public_chats.py:1468: in test_1_1_chat_delete_via_long_press_relogin
    self.home_2.reopen_app()
../views/base_view.py:651: in reopen_app
    sign_in_view.sign_in(password)
../views/sign_in_view.py:296: in sign_in
    self.password_input.send_keys(password)
../views/base_element.py:367: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: EditBox by accessibility id: `password-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:1416: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sent after back up online!



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 1: Looking for a message by text: Hurray! unblocked 

    critical/test_public_chat_browsing.py:967: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Hurray! unblocked was not received in public chat after user unblock!

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    Device sessions

    Passed tests (33)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_leave, id: 702845
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @VolodLytvynenko VolodLytvynenko self-assigned this Sep 21, 2023
    @VolodLytvynenko VolodLytvynenko force-pushed the fix/unread-shell-behaviour branch from 2913341 to 038146e Compare September 21, 2023 08:39
    @status-im-auto
    Copy link
    Member

    100% of end-end tests have passed

    Total executed tests: 3
Failed tests: 0
Passed tests: 3

    Passed tests (3)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    Hi @qfrank. No issues from my side. Please let me know if you plan to push any new commits after PR review, otherwise, the PR can be merged.

    @qfrank
    Copy link
    Contributor

    qfrank commented Sep 21, 2023

    Hi @qfrank. No issues from my side. Please let me know if you plan to push any new commits after PR review, otherwise, the PR can be merged.

    Why was I mentioned? I suppose it was by mistake. 😅

    @VolodLytvynenko
    Copy link
    Contributor

    Hi @qfrank. No issues from my side. Please let me know if you plan to push any new commits after PR review, otherwise, the PR can be merged.

    Why was I mentioned? I suppose it was by mistake. 😅

    @qfrank yes, sorry. Mistakenly mentioned you instead of @Parveshdhull :)

    @Parveshdhull Parveshdhull force-pushed the fix/unread-shell-behaviour branch from 038146e to d327c7e Compare September 21, 2023 11:57
    @Parveshdhull Parveshdhull merged commit db41eb3 into develop Sep 21, 2023
    2 checks passed
    @Parveshdhull Parveshdhull deleted the fix/unread-shell-behaviour branch September 21, 2023 12:23
    ibrkhalil pushed a commit that referenced this pull request Oct 1, 2023
    @Parveshdhull @ibrkhalil
    fix unread badges behavior on Jump-to screen (#17363)
    d3b0061
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @yqrashawn yqrashawn Awaiting requested review from yqrashawn

    @jo-mut jo-mut Awaiting requested review from jo-mut

    @codemaster115 codemaster115 Awaiting requested review from codemaster115

    Assignees

    @Parveshdhull Parveshdhull

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Unread badges behavior on 'Jump-to' screen
    5 participants
    @Parveshdhull @status-im-auto @VolodLytvynenko @qfrank @ibrkhalil