fix: several bugs in 1.25 design feedback #17548

yqrashawn · 2023-10-05T02:39:14Z

fixes #17541
fixes #17529
fixes #17525
fixes #17516
fixes #17510

#17541 and #17516 are both wrong color in action menu issue
I found the color in the implementation is the same as Figma design
danger-50 for light theme #E95460
danger-60 for dark theme #BA434D
screenshots at #17516 (comment) and #17541 (comment)

Summary

recommend to review commit by commit

remove avatar ident ring in long-press selected message screenshot
remove avatar ident ring in message in pinned message view screenshot
fix wrong border width for ring mask in onboarding identicon tab screenshot
refactor: show-user-info? -> in-reaction-and-action-menu? in msg content

status: ready

status-im-auto · 2023-10-05T02:51:35Z

Jenkins Builds

Click to see older builds (7)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`40c0583`	#3	2023-10-05 02:51:35	~2 min	`tests`	📄`log`
✔️	`40c0583`	#3	2023-10-05 02:54:40	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`40c0583`	#3	2023-10-05 02:55:05	~5 min	`android`	🤖`apk` 📲

✔️	`f2c748f`	#4	2023-10-05 03:01:02	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`f2c748f`	#4	2023-10-05 03:02:43	~7 min	`ios`	📱`ipa` 📲
✔️	`f2c748f`	#4	2023-10-05 03:03:20	~7 min	`android`	🤖`apk` 📲
✔️	`f2c748f`	#4	2023-10-05 03:04:54	~9 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`1ccf4a5`	#5	2023-10-05 07:57:15	~5 min	`android`	🤖`apk` 📲
✔️	`1ccf4a5`	#5	2023-10-05 07:58:31	~7 min	`ios`	📱`ipa` 📲
✔️	`1ccf4a5`	#5	2023-10-05 07:59:43	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`1ccf4a5`	#5	2023-10-05 08:00:48	~9 min	`tests`	📄`log`

✔️	`91c218f`	#6	2023-10-06 00:53:26	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`91c218f`	#6	2023-10-06 00:54:27	~6 min	`android`	🤖`apk` 📲
✔️	`91c218f`	#6	2023-10-06 00:55:05	~7 min	`ios`	📱`ipa` 📲
✔️	`91c218f`	#6	2023-10-06 00:58:34	~10 min	`tests`	📄`log`

status-im-auto · 2023-10-05T08:22:51Z

72% of end-end tests have passed

Total executed tests: 43
Failed tests: 12
Passed tests: 31

IDs of failed tests: 702732,703495,702783,702742,703297,703503,702869,703202,702786,702846,702731,702808

Failed tests (12)

Click to expand

Rerun failed tests

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
2. test_group_chat_mute_chat, id: 703495
Device 2: Click until `ChatMessageInput` by `accessibility id`: `chat-message-input` will be presented Device 2: Looking for a message by text: Chat is unmuted now `critical/chats/test_group_chat.py:607: in test_group_chat_mute_chat self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) New messages counter near chats tab button is 1 after unmute, but should be 2` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
3. test_group_chat_send_image_save_and_share, id: 703297
# STEP: Admin checks image message Device 1: Looking for a message by text: test image critical/chats/test_group_chat.py:357: in test_group_chat_send_image_save_and_share self.chats[0].chat_element_by_text(image_description).wait_for_visibility_of_element(60) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'test image')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
4. test_group_chat_reactions, id: 703202
Device 1: Find `EmojisNumber` by `xpath`: `//[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//[@content-desc='emoji-reaction-2']/android.widget.TextView` Device 1: Find `EmojisNumber` by `xpath`: `//[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//[@content-desc='emoji-reaction-2']/android.widget.TextView` critical/chats/test_group_chat.py:252: in test_group_chat_reactions message_element.emojis_below_message(emoji="thumbs-up").wait_for_element_text(2) ../views/base_element.py:181: in wait_for_element_text self.driver.fail(message if message else "`%s` is not equal to expected `%s` in %s sec" % ( base_test_case.py:179: in fail pytest.fail('Device %s: %s' % (self.number, text)) Device 1: `1` is not equal to expected `2` in 30 sec Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
5. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:443: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline` [[Data delivery issue]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_mentions_push_notification, id: 702786

# STEP: Invited member gets push notification with the mention and tap it
Device 2: Getting PN by 'user_2'

critical/test_public_chat_browsing.py:1167: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

[[Issue with username in PN 17396]]

Device sessions

Device 1:

Device 2:

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device 1: ChatMessageInput element not found Device 1: Sending message 'mmmeowesage_text' critical/test_public_chat_browsing.py:382: in test_community_copy_and_paste_message_in_chat_input self.channel.send_message(message) ../views/chat_view.py:995: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_community_discovery, id: 703503
Device 1: Tap on found: Button Device 1: Find `Button` by `xpath`: `//[@text="Contributors' test community"]` critical/test_public_chat_browsing.py:338: in test_community_discovery self.home.element_by_text(contributors_test_community_attributes[0]).click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//[@text="Contributors' test community"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception [[Request to Join Community button color issue:17295]] Device sessions Device 1: Steps, video, logs Failure screenshot
3. test_community_undo_delete_message, id: 702869
Device 1: ChatMessageInput element not found Device 1: Sending message 'message to delete and undo' critical/test_public_chat_browsing.py:397: in test_community_undo_delete_message self.channel.send_message(message_to_delete) ../views/chat_view.py:995: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device 1: ChatMessageInput element not found Device 1: Sending message 'some_text' critical/test_public_chat_browsing.py:368: in test_community_navigate_to_channel_when_relaunch self.channel.send_message(text_message) ../views/chat_view.py:995: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-status']/android.widget.TextView` Device 2: `Text` is `Sent` `critical/chats/test_1_1_public_chats.py:1417: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message status was not changed to Delivered, it's Sent after back up online!` [[Data delivery issue]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (31)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

qoqobolo · 2023-10-05T11:39:38Z

Thanks for the fixes @yqrashawn, nice job!
@Francesca-G could you check the changes, please?

Francesca-G

Mentioned issues look good ✨

Not related to this PR, while checking I used an account that had a very long name and this happened:

Not sure if this is a known issue, if this hasn't been reported yet please create the related follow up 🙏

qoqobolo · 2023-10-05T13:19:09Z

Not sure if this is a known issue, if this hasn't been reported yet please create the related follow up 🙏

Yep, already logged 👌
#17217

fix #17510

fix #17525

fix #17529

Signed-off-by: yqrashawn <namy.19@gmail.com>

yqrashawn changed the title ~~fix: several bug from 1.25 design feedback~~ fix: several bugs in 1.25 design feedback Oct 5, 2023

yqrashawn force-pushed the fix/rashawn/1.25-design-feedback branch from 338eec4 to 3f8e807 Compare October 5, 2023 02:44

yqrashawn requested review from alwx, smohamedjavid, J-Son89 and jo-mut October 5, 2023 02:51

yqrashawn added E:Design Feedback 1.25 request-manual-qa and removed E:Design Feedback 1.25 labels Oct 5, 2023

yqrashawn self-assigned this Oct 5, 2023

yqrashawn force-pushed the fix/rashawn/1.25-design-feedback branch from 40c0583 to f2c748f Compare October 5, 2023 02:55

ibrkhalil approved these changes Oct 5, 2023

View reviewed changes

J-Son89 approved these changes Oct 5, 2023

View reviewed changes

yqrashawn force-pushed the fix/rashawn/1.25-design-feedback branch from f2c748f to 1ccf4a5 Compare October 5, 2023 07:51

smohamedjavid approved these changes Oct 5, 2023

View reviewed changes

qoqobolo self-assigned this Oct 5, 2023

qoqobolo added the Tested - OK label Oct 5, 2023

Francesca-G approved these changes Oct 5, 2023

View reviewed changes

jo-mut approved these changes Oct 5, 2023

View reviewed changes

yqrashawn added 2 commits October 6, 2023 08:41

fix: no ring in long-press selected message

9a2c0e4

fix #17510

fix: no ident ring for message user-avatar in pinned view

1137521

fix #17525

yqrashawn added 2 commits October 6, 2023 08:43

fix: wrong border width for ring mask in onboarding identicon tab

5640b4c

fix #17529

refactor: show-user-info? -> in-reaction-and-action-menu? in msg content

91c218f

Signed-off-by: yqrashawn <namy.19@gmail.com>

yqrashawn force-pushed the fix/rashawn/1.25-design-feedback branch from 1ccf4a5 to 91c218f Compare October 6, 2023 00:47

yqrashawn merged commit afbd890 into develop Oct 6, 2023
2 checks passed

yqrashawn deleted the fix/rashawn/1.25-design-feedback branch October 6, 2023 07:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: several bugs in 1.25 design feedback #17548

fix: several bugs in 1.25 design feedback #17548

yqrashawn commented Oct 5, 2023 •

edited

Loading

status-im-auto commented Oct 5, 2023 •

edited

Loading

status-im-auto commented Oct 5, 2023

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityMultipleDevicePRTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

qoqobolo commented Oct 5, 2023

Francesca-G left a comment

qoqobolo commented Oct 5, 2023

fix: several bugs in 1.25 design feedback #17548

fix: several bugs in 1.25 design feedback #17548

Conversation

yqrashawn commented Oct 5, 2023 • edited Loading

Summary

status-im-auto commented Oct 5, 2023 • edited Loading

Jenkins Builds

status-im-auto commented Oct 5, 2023

72% of end-end tests have passed

Failed tests (12)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Passed tests (31)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityMultipleDevicePRTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

qoqobolo commented Oct 5, 2023

Francesca-G left a comment

Choose a reason for hiding this comment

qoqobolo commented Oct 5, 2023

yqrashawn commented Oct 5, 2023 •

edited

Loading

status-im-auto commented Oct 5, 2023 •

edited

Loading