Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] network-routing component test #17760

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[Fix] network-routing component test #17760

merged 1 commit into from
Oct 30, 2023

Conversation

smohamedjavid
Copy link
Member

Summary

This PR moves the network-routing component test to the quo ns from quo2 ns.

With this, the quo2 directory is completely removed.

Testing notes

This PR doesn't require any manual testing as it moves the component test for a component to its rightful place/namespace.

status: ready

@smohamedjavid smohamedjavid self-assigned this Oct 30, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Oct 30, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 97a3b9c #1 2023-10-30 11:41:47 ~3 min tests 📄log
✔️ 97a3b9c #1 2023-10-30 11:44:18 ~5 min android 🤖apk 📲
✔️ 97a3b9c #1 2023-10-30 11:44:40 ~6 min android-e2e 🤖apk 📲
✔️ 97a3b9c #1 2023-10-30 11:50:53 ~12 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3cb180e #2 2023-10-30 12:03:45 ~7 min ios 📱ipa 📲
✔️ 3cb180e #2 2023-10-30 12:05:19 ~8 min android 🤖apk 📲
✔️ 3cb180e #2 2023-10-30 12:05:19 ~8 min android-e2e 🤖apk 📲
✔️ 3cb180e #2 2023-10-30 12:07:07 ~10 min tests 📄log
✔️ 80f924c #3 2023-10-30 15:13:42 ~12 min android-e2e 🤖apk 📲
✔️ 80f924c #3 2023-10-30 15:15:04 ~13 min android 🤖apk 📲
✔️ 80f924c #3 2023-10-30 15:18:32 ~17 min ios 📱ipa 📲
✔️ 80f924c #3 2023-10-30 15:20:46 ~19 min tests 📄log

flexsurfer
flexsurfer reviewed Oct 30, 2023
View reviewed changes
.clj-kondo/taoensso/encore/taoensso/encore.clj Outdated
@@ -0,0 +1,16 @@
(ns taoensso.encore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you pls elaborate on how this related to PR?

Copy link
Member Author

@smohamedjavid smohamedjavid Oct 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related to the PR.

These files need to be committed as these are generated by encore clj-kondo.
https://discord.com/channels/1103692771585433630/1103692773363810317/1166397710941814794

I can remove these changes if not required.

EDIT: Apologies for not adding the link/description in the first place.

@smohamedjavid smohamedjavid force-pushed the fix/network-routing-component-test branch from 97a3b9c to 3cb180e Compare October 30, 2023 11:56
@status-im-auto
Copy link
Member

87% of end-end tests have passed

Total executed tests: 45
Failed tests: 3
Expected to fail tests: 3
Passed tests: 39

IDs of failed tests: 702813,702786,702807 

IDs of expected to fail tests: 702732,702731,702808

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'user_2'
    Device 2: Looking for a message by text: user_2 

    critical/chats/test_public_chat_browsing.py:882: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Channel did not open by clicking on a notification with the mention for admin
E    Edited message is not shown correctly for the sender
E    Edited message is not shown correctly for the (receiver) admin
E    Channel did not open by clicking on a notification with the mention for the invited member



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813

    Device 1: App to background
    Device 2: Sending message 'emoji' 

    critical/chats/test_1_1_public_chats.py:345: in test_1_1_chat_push_emoji
    chat_2.send_message(emoji.emojize(emoji_message))
../views/chat_view.py:1000: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Text is Delivered
    Device 1: Looking for a message by text: Hey, admin! 

    critical/chats/test_group_chat.py:97: in test_group_chat_join_send_text_messages_push
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message Hey, admin! was not received by admin



    Device sessions

    Expected to fail tests (3)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:309: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Passed tests (39)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    6. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_discovery, id: 703503
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    6. test_community_mute_community_and_channel, id: 703382
    Device sessions

    @smohamedjavid
    Copy link
    Member Author

    @status-im/mobile-qa - There are three failed test cases. I believe it's not related to this PR. Please help me confirm.

    @VolodLytvynenko
    Copy link
    Contributor

    Hi @smohamedjavid . The e2e failed tests are not related to the current PR. Thanx

    @smohamedjavid
    Copy link
    Member Author

    Thanks for the confirmation @VolodLytvynenko!

    @smohamedjavid
    [Fix] network-routing component test
    80f924c 
    Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    @smohamedjavid smohamedjavid force-pushed the fix/network-routing-component-test branch from 3cb180e to 80f924c Compare October 30, 2023 15:01
    @smohamedjavid smohamedjavid merged commit dd8beeb into develop Oct 30, 2023
    2 checks passed
    @smohamedjavid smohamedjavid deleted the fix/network-routing-component-test branch October 30, 2023 15:21
    yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023
    @smohamedjavid @yevh-berdnyk
    [Fix] "network-routing" component test (#17760)
    f08e4e3 
    This commit moves the "network-routing" component test to the quo ns from quo2 ns.

Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @ulisesmac ulisesmac Awaiting requested review from ulisesmac

    Assignees

    @smohamedjavid smohamedjavid

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @smohamedjavid @status-im-auto @VolodLytvynenko @flexsurfer @J-Son89