-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate reagent atom part 1 #18901
Migrate reagent atom part 1 #18901
Conversation
Jenkins BuildsClick to see older builds (35)
|
b0087b4
to
ac7c6fd
Compare
12% of end-end tests have passed
Failed tests (41)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (6)Click to expandClass TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
|
hey @status-im/mobile-qa could someone take a look pls whats wrong with e2e, thank you |
12% of end-end tests have passed
Failed tests (41)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (6)Click to expandClass TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
|
Hey @flexsurfer, unfortunately, we're experiencing failed e2e tests globally due to a recently merged PR. They should start working more stable after merging this PR: #18919. Apologies for such inconvenience. I let you know when e2e can be rerun |
@VolodLytvynenko this is wrong. E2E are failing because our develop is currently broken due to this issue. @flexsurfer We will provide an update when the problem is fixed. |
032fd93
to
7c9dcd5
Compare
7c9dcd5
to
2324529
Compare
2324529
to
1078fad
Compare
56% of end-end tests have passed
Failed tests (20)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (27)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
|
@status-im/mobile-qa could you pls take a look at e2e |
Reviewed e2e in #18905 which includes changes from these PR. They are okay. Current failures are not PR related. |
This PR is the first step in migrating from reagent atom to react state, also it changes theme context usage and use-callback for anon functions
slide button is a good example of how components can be simplified and improved https://github.com/status-im/status-mobile/pull/18901/files#diff-0ad4df96fe272774e325a17c8b955035d50f1f9ec6802c1aae5f52dd763fae52
two effects have been eliminated