[#18929] fix: no bottom space under the join button #18987

mohsen-ghafouri · 2024-02-23T20:13:58Z

fixes #18929
fixes #18997

Summary

No bottom space under the 'Slide to request to join' button

Platforms

Android
iOS (SE)

Result

status: ready

status-im-auto · 2024-02-23T20:19:48Z

Jenkins Builds

Click to see older builds (15)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`ec4cabb`	#1	2024-02-23 20:19:47	~5 min	`tests`	📄`log`
✔️	`ec4cabb`	#1	2024-02-23 20:21:05	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`ec4cabb`	#1	2024-02-23 20:22:18	~7 min	`android`	🤖`apk` 📲
✔️	`ec4cabb`	#1	2024-02-23 20:22:40	~8 min	`ios`	📱`ipa` 📲

✔️	`f83250d`	#2	2024-03-01 06:30:55	~6 min	`tests`	📄`log`
✔️	`f83250d`	#2	2024-03-01 06:32:33	~7 min	`android`	🤖`apk` 📲
✔️	`f83250d`	#2	2024-03-01 06:32:33	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`f83250d`	#2	2024-03-01 06:36:35	~11 min	`ios`	📱`ipa` 📲

✔️	`0a3a2ae`	#3	2024-03-03 12:22:02	~6 min	`tests`	📄`log`
✔️	`0a3a2ae`	#3	2024-03-03 12:23:10	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`0a3a2ae`	#3	2024-03-03 12:23:16	~7 min	`android`	🤖`apk` 📲
✔️	`0a3a2ae`	#3	2024-03-03 12:31:20	~15 min	`ios`	📱`ipa` 📲

✔️	`c0c2070`	#4	2024-03-06 12:22:58	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`c0c2070`	#4	2024-03-06 12:23:25	~6 min	`android`	🤖`apk` 📲
✔️	`c0c2070`	#4	2024-03-06 12:24:10	~7 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`0cb971b`	#5	2024-03-06 16:29:23	~6 min	`tests`	📄`log`
✔️	`0cb971b`	#5	2024-03-06 16:30:08	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`0cb971b`	#5	2024-03-06 16:30:16	~7 min	`android`	🤖`apk` 📲
✔️	`0cb971b`	#5	2024-03-06 16:30:51	~8 min	`ios`	📱`ipa` 📲

✔️	`728ae92`	#6	2024-03-08 16:19:43	~6 min	`tests`	📄`log`
✔️	`728ae92`	#6	2024-03-08 16:20:10	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`728ae92`	#6	2024-03-08 16:21:55	~8 min	`android`	🤖`apk` 📲
✔️	`728ae92`	#6	2024-03-08 16:22:03	~8 min	`ios`	📱`ipa` 📲

seanstrom

Looks good! I left one small comment about consistency between iOS and Android.

src/status_im/contexts/communities/actions/accounts_selection/style.cljs

status-im-auto · 2024-02-29T20:41:57Z

12% of end-end tests have passed

Total executed tests: 48
Failed tests: 41
Expected to fail tests: 1
Passed tests: 6

IDs of failed tests: 702809,702782,702733,702784,703194,702859,702777,702732,702813,703133,702957,702851,702840,703495,703086,702948,702894,702745,702783,702850,703297,704615,703496,702936,702855,703202,703391,702786,702839,702947,702838,702844,702843,702807,702731,702808,702730,702845,702958,703629,702841

IDs of expected to fail tests: 703503

Failed tests (41)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
2. test_community_one_image_send_reply, id: 702859
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
3. test_community_emoji_send_copy_paste_reply, id: 702840
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
4. test_community_mark_all_messages_as_read, id: 703086
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
5. test_community_contact_block_unblock_offline, id: 702894
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
6. test_community_edit_delete_message_when_offline, id: 704615
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
7. test_community_message_delete, id: 702839
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
10. test_community_message_edit, id: 702843
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
11. test_community_unread_messages_badge, id: 702841
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
2. test_group_chat_mute_chat, id: 703495
Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
3. test_group_chat_send_image_save_and_share, id: 703297
Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
4. test_group_chat_reactions, id: 703202
Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
5. test_group_chat_join_send_text_messages_push, id: 702807
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
6. test_group_chat_offline_pn, id: 702808
Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Test setup failed: critical/chats/test_public_chat_browsing.py:818: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
2. test_community_hashtag_links_to_community_channels, id: 702948
Test setup failed: critical/chats/test_public_chat_browsing.py:818: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
3. test_community_mentions_push_notification, id: 702786
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: critical/chats/test_public_chat_browsing.py:818: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_community_leave, id: 702845
Test setup failed: critical/chats/test_public_chat_browsing.py:818: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
5. test_community_join_when_node_owner_offline, id: 703629
Test setup failed: critical/chats/test_public_chat_browsing.py:818: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: activity_center/test_activity_center.py:246: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Test setup failed: activity_center/test_activity_center.py:246: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: activity_center/test_activity_center.py:393: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Test setup failed: activity_center/test_activity_center.py:393: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center activity_center/test_activity_center.py:190: in test_add_contact_field_validation self.home_2.handle_contact_request(new_username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'test user 123')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device 1: Find `ChatsTab` by `accessibility id`: `chats-stack-tab` Device 1: Tap on found: ChatsTab activity_center/test_activity_center.py:112: in test_activity_center_contact_request_accept_swipe_mark_all_as_read self.home_1.notifications_unread_badge.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: BaseElement by accessibility id:`activity-center-unread-count` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_activity_center_contact_request_decline, id: 702850
Device 1: Tap on found: Button Device 1: Find `Text` by `xpath`: `//[@content-desc="pending-contact-requests-count"]/android.widget.TextView` activity_center/test_activity_center.py:69: in test_activity_center_contact_request_decline if self.home_1.pending_contact_request_text.text != '1': ../views/base_element.py:415: in text text = self.find_element().text ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Text by xpath: `//[@content-desc="pending-contact-requests-count"]/android.widget.TextView` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device 1: Find Button by accessibility id: show-profiles
Device 1: Tap on found: Button

critical/chats/test_public_chat_browsing.py:276: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 zQ3...dWXh5 was not restored as a contact from waku backup!
E    zQ3...Vacac was not restored as a contact from waku backup!
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!

Device sessions

Device 1:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Test setup failed: critical/chats/test_1_1_public_chats.py:546: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: critical/chats/test_1_1_public_chats.py:546: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_mute_chat, id: 703496
Test setup failed: critical/chats/test_1_1_public_chats.py:546: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
3. test_1_1_chat_push_emoji, id: 702813
Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
5. test_1_1_chat_edit_message, id: 702855
Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
6. test_1_1_chat_send_image_save_and_share, id: 703391
Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
7. test_1_1_chat_pin_messages, id: 702731
Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
8. test_1_1_chat_message_reaction, id: 702730
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (6)

Click to expand

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
3. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
4. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

status-im-auto · 2024-03-01T07:44:41Z

92% of end-end tests have passed

Total executed tests: 48
Failed tests: 3
Expected to fail tests: 1
Passed tests: 44

IDs of failed tests: 702809,702948,703202

IDs of expected to fail tests: 703503

Failed tests (3)

Click to expand

Rerun failed tests

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_reactions, id: 703202

Device 2: Looking for a message by text: This is a test message to check some reactions.
Device 2: Find `ChatElementByText` by `xpath`: `//*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`

critical/chats/test_group_chat.py:109: in test_group_chat_reactions
    self.chats[1].set_reaction(message=message, emoji="thumbs-up")
../views/chat_view.py:1084: in set_reaction
    self.chat_element_by_text(message).long_press_until_element_is_shown(element)
../views/base_element.py:326: in long_press_until_element_is_shown
    element = self.find_element()
../views/chat_view.py:134: in find_element
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Device 2:

Device 3:

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device 1: Looking for a message by text: quote reply (one row) Device 2: Looking for a message by text: quote reply (one row) critical/chats/test_public_chat_browsing.py:980: in test_community_markdown_support self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) italic text in asteric is not displayed with markdown in community channel for the recipient (device 1) E E italic text in underscore is not displayed with markdown in community channel for the recipient (device 1) E E inline code is not displayed with markdown in community channel for the recipient (device 1) E E quote reply (one row) is not displayed with markdown in community channel for the recipient (device 1) Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_hashtag_links_to_community_channels, id: 702948
Device 1: Click until `ChatMessageInput` by `accessibility id`: `chat-message-input` will be presented Device 1: Looking for a message by text: #cats critical/chats/test_public_chat_browsing.py:1082: in test_community_hashtag_links_to_community_channels self.chat_1.chat_element_by_text(message_with_hashtag).click_on_link_inside_message_body() ../views/chat_view.py:193: in click_on_link_inside_message_body self.message_body.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (44)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

mariia-skrypnyk · 2024-03-06T13:53:26Z

Hi @mohsen-ghafouri !

Issue on SE is fixed but new one appeared on bigger models (too big margin)

iPhone 13:

mohsen-ghafouri · 2024-03-06T16:25:18Z

Thank you @mariia-skrypnyk for testing this PR, please check again.

mariia-skrypnyk · 2024-03-06T17:59:03Z

Hi @mohsen-ghafouri !

iPhone is fixed thanks!

But I've compared 2 android builds: last one and previous (March 6) and on the last one I found such new issue:

ISSUE 2: Avatar is too close to status bar

ISSUE 3: bottom space under the join button on Android

*it was not only at the last android build but I found it only now (sorry for this) while using dark theme.
I think iOS and Android should have the same bottom space. Let me know if it also works for you!

mohsen-ghafouri · 2024-03-06T21:29:52Z

@mariia-skrypnyk for issue 3, in iOS there are more spaces above handler, as you can see the white area below the green section is safe area, we added the same padding(12px) in both iOS and android.

for issue 2 i don't think it's related to my PR, I only apply changes to the bottom of "Request to join" screen, the screenshot doesn't seem to be related to this screen.

mariia-skrypnyk · 2024-03-07T08:36:31Z

@mariia-skrypnyk for issue 3, in iOS there are more spaces above handler, as you can see the white area below the green section is safe area, we added the same padding(12px) in both iOS and android.
for issue 2 i don't think it's related to my PR, I only apply changes to the bottom of "Request to join" screen, the screenshot doesn't seem to be related to this screen.

Hi @mohsen-ghafouri !

Yes, I was not sure in issue 3.
I'll continue investigating issue 2 as it's not your interruption.
Thanks for explaining.
I'll move your PR to the design review.
@Francesca-G please, do not address status bar issue to this PR, I'll investigate it not here.

Francesca-G

Bottom margin doesn't match design, Figma comment here

mohsen-ghafouri · 2024-03-08T14:11:05Z

Hey @Francesca-G, thank you for reviewing this. please check this comment #18987 (comment)

this is safe area that provide by OS. we have this space also in other modals

Francesca-G

@mohsen-ghafouri apologies and thanks for the clarification 🙏

Looks good to me!

mohsen-ghafouri requested review from FFFra and ajayesivan February 23, 2024 20:13

mohsen-ghafouri self-assigned this Feb 23, 2024

mohsen-ghafouri requested review from ilmotta, jo-mut and a team February 28, 2024 16:50

flexsurfer removed the request for review from a team February 29, 2024 14:35

seanstrom reviewed Feb 29, 2024

View reviewed changes

src/status_im/contexts/communities/actions/accounts_selection/style.cljs Outdated Show resolved Hide resolved

seanstrom approved these changes Feb 29, 2024

View reviewed changes

ilmotta approved these changes Feb 29, 2024

View reviewed changes

mohsen-ghafouri force-pushed the fix/join-bottom-space branch from ec4cabb to f83250d Compare March 1, 2024 06:24

mohsen-ghafouri added the request-manual-qa label Mar 1, 2024

Parveshdhull approved these changes Mar 1, 2024

View reviewed changes

smohamedjavid approved these changes Mar 1, 2024

View reviewed changes

pavloburykh force-pushed the fix/join-bottom-space branch from f83250d to 0a3a2ae Compare March 3, 2024 12:15

ibrkhalil approved these changes Mar 3, 2024

View reviewed changes

mariia-skrypnyk self-assigned this Mar 6, 2024

pavloburykh force-pushed the fix/join-bottom-space branch from 0a3a2ae to c0c2070 Compare March 6, 2024 12:16

jo-mut approved these changes Mar 6, 2024

View reviewed changes

mariia-skrypnyk added the Tested - Issues label Mar 6, 2024

mohsen-ghafouri force-pushed the fix/join-bottom-space branch from c0c2070 to 0cb971b Compare March 6, 2024 16:22

mariia-skrypnyk added Tested - OK and removed Tested - Issues labels Mar 7, 2024

Francesca-G reviewed Mar 8, 2024

View reviewed changes

Francesca-G approved these changes Mar 8, 2024

View reviewed changes

mohsen-ghafouri added 2 commits March 8, 2024 19:12

[#18929] fix: no bottom space under the join button

31a13f6

[#18929] fix: remove extra space

728ae92

mohsen-ghafouri force-pushed the fix/join-bottom-space branch from 0cb971b to 728ae92 Compare March 8, 2024 16:12

mohsen-ghafouri merged commit 7a6714e into develop Mar 8, 2024
6 checks passed

mohsen-ghafouri deleted the fix/join-bottom-space branch March 8, 2024 16:24

Francesca-G mentioned this pull request Mar 18, 2024

Composer - Photo selection drawer issues #19312

Closed

[#18929] fix: no bottom space under the join button #18987

[#18929] fix: no bottom space under the join button #18987

Conversation

mohsen-ghafouri commented Feb 23, 2024 • edited Loading

Summary

Platforms

Result

status-im-auto commented Feb 23, 2024 • edited Loading

Jenkins Builds

seanstrom left a comment

Choose a reason for hiding this comment

status-im-auto commented Feb 29, 2024

12% of end-end tests have passed

Failed tests (41)

Class TestCommunityMultipleDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePR:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (6)

Class TestDeepLinksOneDevice:

Class TestCommunityOneDeviceMerged:

status-im-auto commented Mar 1, 2024

92% of end-end tests have passed

Failed tests (3)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMergedTwo:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (44)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestDeepLinksOneDevice:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityCenterContactRequestMultipleDevicePR:

mariia-skrypnyk commented Mar 6, 2024 • edited Loading

mohsen-ghafouri commented Mar 6, 2024

mariia-skrypnyk commented Mar 6, 2024 • edited Loading

mohsen-ghafouri commented Mar 6, 2024 • edited Loading

mariia-skrypnyk commented Mar 7, 2024

Francesca-G left a comment

Choose a reason for hiding this comment

mohsen-ghafouri commented Mar 8, 2024 • edited Loading

Francesca-G left a comment

Choose a reason for hiding this comment

mohsen-ghafouri commented Feb 23, 2024 •

edited

Loading

status-im-auto commented Feb 23, 2024 •

edited

Loading

mariia-skrypnyk commented Mar 6, 2024 •

edited

Loading

mariia-skrypnyk commented Mar 6, 2024 •

edited

Loading

mohsen-ghafouri commented Mar 6, 2024 •

edited

Loading

mohsen-ghafouri commented Mar 8, 2024 •

edited

Loading