-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix multiple set view-id events dispatched #19083
Conversation
Jenkins BuildsClick to see older builds (18)
|
d665c92
to
163a542
Compare
src/status_im/navigation/core.cljs
Outdated
(fn [] (gesture/gesture-handler-root-hoc views/bottom-sheet)) | ||
(fn [] views/bottom-sheet)) | ||
(defonce | ||
_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we not just have a navigation init function that registers these somewhere in the app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, moved to status-im.core
.
Functions called in defonce
were being called just before init
function, So hopefully it will not have any side effect and will work same. cc @flexsurfer @J-Son89
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, looks good to me!
75% of end-end tests have passed
Failed tests (11)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (36)Click to expandClass TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
0c62ea3
to
437c011
Compare
81% of end-end tests have passed
Failed tests (8)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (39)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
|
@status-im/mobile-qa Please can you look into failed tests? |
437c011
to
c063892
Compare
38% of end-end tests have passed
Failed tests (5)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (3)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
100% of end-end tests have passed
Passed tests (5)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
Hi @Parveshdhull the failures are not PR related. Thank you for PR. If no necessity to test it manually then PR can be merged. Thank you |
c063892
to
38c6387
Compare
fixes #18811
related to: https://discord.com/channels/1103692771585433630/1103692773363810317/1212833784869683300 (@flexsurfer)
Every time app reloaded,
reg-modal-dismissed-listener
was being called and was behaving strange and firing set-view-id event multiple times (same times the app refreshed). Issue was in debug only.@ibrkhalil Thank you for reporting wrong view-id for settings screen. Most probably this was caused by this same bug, where we are getting set-view-id being called multiple times and leading to wrong value. I checked Android and its working now. If you have access to IOS, please let me know if its right for you too. Thank you
Testing
No manual testing is required for the PR.
status: ready