fix: unresponsive add watched address screen when entering a multi-chain address #19185

briansztamfater · 2024-03-11T16:32:23Z

Summary

This PR aims to fix unresponsive add watched address screen when entering a multi-chain address. The approach I took is to extract the plain address from the multi-chain address so status-go endpoint doesn't return an error and the flow continues as expected. Either way address is watched for all the available chains.

Platforms

Android
iOS

Areas that maybe impacted

Functional

wallet / transactions

Steps to test

Open Status
Navigate to the Wallet tab
Tap on + to add new watch address
Enter a multichain address (Eg: eth:opt:arb1:0x9bf27d0c9aba562dc33bc4b60c233a6609ce2987)
Tap on Confirm to navigate to the next screen
Enter a name
Tap on Add watched address
Verify the screen is responsive and the watched address is created successfully

status: ready

status-im-auto · 2024-03-11T16:39:23Z

Jenkins Builds

Click to see older builds (8)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`0d053f6`	#1	2024-03-11 16:39:22	~6 min	`tests`	📄`log`
✔️	`0d053f6`	#1	2024-03-11 16:41:17	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`0d053f6`	#1	2024-03-11 16:41:34	~8 min	`android`	🤖`apk` 📲
✔️	`0d053f6`	#1	2024-03-11 16:44:30	~11 min	`ios`	📱`ipa` 📲

✔️	`7c10fda`	#3	2024-03-14 18:40:34	~5 min	`tests`	📄`log`
✔️	`7c10fda`	#3	2024-03-14 18:41:24	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`7c10fda`	#3	2024-03-14 18:41:33	~6 min	`android`	🤖`apk` 📲
✔️	`7c10fda`	#3	2024-03-14 18:43:16	~8 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`7194682`	#4	2024-03-19 17:21:27	~5 min	`tests`	📄`log`
✔️	`7194682`	#4	2024-03-19 17:21:57	~6 min	`android`	🤖`apk` 📲
✔️	`7194682`	#4	2024-03-19 17:22:43	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`7194682`	#4	2024-03-19 17:24:38	~9 min	`ios`	📱`ipa` 📲

✔️	`211901a`	#5	2024-03-20 16:39:37	~6 min	`tests`	📄`log`
✔️	`211901a`	#5	2024-03-20 16:40:09	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`211901a`	#5	2024-03-20 16:41:24	~7 min	`android`	🤖`apk` 📲
✔️	`211901a`	#5	2024-03-20 16:57:53	~24 min	`ios`	📱`ipa` 📲

smohamedjavid

Nice 👌

status-im-auto · 2024-03-12T14:53:33Z

81% of end-end tests have passed

Total executed tests: 48
Failed tests: 8
Expected to fail tests: 1
Passed tests: 39

IDs of failed tests: 702855,702745,702731,702851,702733,702813,702782,703391

IDs of expected to fail tests: 703503

Failed tests (8)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855
Device 2: Could not reach home view by pressing system back button Device 2: Find `Button` by `accessibility id`: `jump-to` critical/chats/test_1_1_public_chats.py:372: in test_1_1_chat_edit_message self.chat_2.jump_to_card_by_text(self.username_1) ../views/base_view.py:659: in jump_to_card_by_text self.click_on_floating_jump_to() ../views/base_view.py:648: in click_on_floating_jump_to self.jump_to_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `jump-to` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 1: Find `Button` by `xpath`: `//*[@text='Allow all']` Device 1: Tap on found: Button critical/chats/test_1_1_public_chats.py:273: in test_1_1_chat_non_latin_messages_stack_update_profile_photo self.profile_1.edit_profile_picture(image_index=2) ../views/profile_view.py:449: in edit_profile_picture self.select_photo_from_gallery_by_index(image_index) ../views/profile_view.py:478: in select_photo_from_gallery_by_index raise NoSuchElementException("Image with index %s was not found" % image_index) from None Image with index 2 was not found; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_pin_messages, id: 702731
Device 1: Find `Button` by `xpath`: `//[@content-desc='pins-count']//android.widget.TextView` Device 2: Find `Button` by `xpath`: `//[@content-desc='pins-count']//android.widget.TextView` `critical/chats/test_1_1_public_chats.py:267: in test_1_1_chat_pin_messages self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Pinned messages count is 4 but should be 3 for user 2` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device 2: Find `Button` by `accessibility id`: `jump-to` critical/chats/test_1_1_public_chats.py:459: in test_1_1_chat_text_message_delete_push_disappear self.chat_2.jump_to_card_by_text(self.username_1) ../views/base_view.py:659: in jump_to_card_by_text self.click_on_floating_jump_to() ../views/base_view.py:648: in click_on_floating_jump_to self.jump_to_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `jump-to` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
5. test_1_1_chat_push_emoji, id: 702813
Device 1: Click until `ChatMessageInput` by `accessibility id`: `chat-message-input` will be presented Device 1: Sending message 'Text push notification' critical/chats/test_1_1_public_chats.py:329: in test_1_1_chat_push_emoji self.chat_1.send_message(message) ../views/chat_view.py:1014: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:129: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
6. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device 2: Find `OpenInStatusButton` by `xpath`: `//*[@text="Open in Status"]` Device 2: Tap on found: OpenInStatusButton `critical/chats/test_1_1_public_chats.py:178: in test_1_1_chat_emoji_send_reply_and_open_link self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Reply for 'Test with link: https://status.im/ here should be nothing unusual.' not present in message received in public chat` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
7. test_1_1_chat_send_image_save_and_share, id: 703391
Device 2: Find `Button` by `accessibility id`: `jump-to` critical/chats/test_1_1_public_chats.py:398: in test_1_1_chat_send_image_save_and_share self.chat_2.jump_to_card_by_text(self.username_1) ../views/base_view.py:659: in jump_to_card_by_text self.click_on_floating_jump_to() ../views/base_view.py:648: in click_on_floating_jump_to self.jump_to_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `jump-to` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device 1: Tap on found: Button
# STEP: Device1 check that contact appeared in contact list mutually

/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
    httplib_response = self._make_request(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
    six.raise_from(e, None)
<string>:3: in raise_from
    ???
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
    httplib_response = conn.getresponse()
/usr/lib/python3.10/http/client.py:1375: in getresponse
    response.begin()
/usr/lib/python3.10/http/client.py:318: in begin
    version, status, reason = self._read_status()
/usr/lib/python3.10/http/client.py:287: in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
E   http.client.RemoteDisconnected: Remote end closed connection without response

During handling of the above exception, another exception occurred:
activity_center/test_activity_center.py:134: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.device_2.just_fyi('Device1 check that contact appeared in contact list mutually')
../views/base_view.py:395: in just_fyi
    self.driver.execute_script("sauce:context=STEP: %s" % some_str)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:405: in execute_script
    return self.execute(command, {"script": script, "args": converted_args})["value"]
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:343: in execute
    response = self.command_executor.execute(driver_command, params)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:291: in execute
    return self._request(command_info[0], url, body=data)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:312: in _request
    response = self._conn.request(method, url, body=body, headers=headers)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:78: in request
    return self.request_encode_body(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:170: in request_encode_body
    return self.urlopen(method, url, **extra_kw)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/poolmanager.py:376: in urlopen
    response = conn.urlopen(method, u.request_uri, **kw)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:787: in urlopen
    retries = retries.increment(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/util/retry.py:550: in increment
    raise six.reraise(type(error), error, _stacktrace)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/packages/six.py:769: in reraise
    raise value.with_traceback(tb)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
    httplib_response = self._make_request(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
    six.raise_from(e, None)
<string>:3: in raise_from
    ???
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
    httplib_response = conn.getresponse()
/usr/lib/python3.10/http/client.py:1375: in getresponse
    response.begin()
/usr/lib/python3.10/http/client.py:318: in begin
    version, status, reason = self._read_status()
/usr/lib/python3.10/http/client.py:287: in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
 ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

Device sessions

Device 1:

Device 2:

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (39)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
6. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
4. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs
2. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs

ulisesmac · 2024-03-12T17:11:59Z

src/status_im/contexts/wallet/add_address_to_watch/view.cljs

@@ -22,6 +23,10 @@
     (or (validation/eth-address? user-input)
         (validation/ens-name? user-input))) (i18n/label :t/invalid-address)))

+(defn- extract-address
+  [scanned-text]
+  (first (re-seq constants/regx-address-contains scanned-text)))


We might want to just use re-find since it returns the first match.

re-find
re-seq

Additionally, I'm wondering what happens when it's not found? is that case properly handled?

Thanks @ulisesmac, updated the function :)

Additionally, I'm wondering what happens when it's not found? is that case properly handled?

That should not happen as we are calling extract-address with :wallet/watch-address-validated-address sub value, and it always returns a valid address. If there's no valid address the button is disabled and extract-address is never called.

Ok 👍 thanks for the explanation

status-im-auto · 2024-03-12T17:34:42Z

94% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Expected to fail tests: 1
Passed tests: 45

IDs of failed tests: 702844,702730

IDs of expected to fail tests: 703503

Failed tests (2)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_message_reaction, id: 702730
Device 1: Find `EmojisNumber` by `xpath`: `//[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//[@content-desc='emoji-reaction-2']/android.widget.TextView[2]` Device 1: Find `EmojisNumber` by `xpath`: `//[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//[@content-desc='emoji-reaction-2']/android.widget.TextView[2]` critical/chats/test_1_1_public_chats.py:67: in test_1_1_chat_message_reaction message_sender.emojis_below_message(emoji="thumbs-up").wait_for_element_text(2, 90) ../views/base_element.py:190: in wait_for_element_text self.driver.fail(message if message else "`%s` is not equal to expected `%s` in %s sec" % ( base_test_case.py:179: in fail pytest.fail('Device %s: %s' % (self.number, text)) Device 1: `1` is not equal to expected `2` in 90 sec Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMerged:

1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

Device 2: Tap on found: SendMessageButton
Device 1: Getting preview message for link: https://m.youtube.com/watch?v=Je7yErjEVt4

critical/chats/test_public_chat_browsing.py:585: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
    message.wait_for_element(60)
../views/base_element.py:129: in wait_for_element
    raise TimeoutException(
 Device `1`: `PreviewMessage` by` xpath`: `//*[starts-with(@text,'https://m.youtube.com/watch?v=Je7yErjEVt4')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element

Device sessions

Device 1:

Device 2:

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (45)

Click to expand

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
6. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

mariia-skrypnyk · 2024-03-19T18:49:24Z

Hi @briansztamfater !
Thanks for your fix! Great job!
You can merge it.

…ain address

briansztamfater added the request-manual-qa label Mar 11, 2024

briansztamfater requested review from shivekkhurana, rasom, vkjr, FFFra, smohamedjavid, J-Son89, OmarBasem, mmilad75 and ulisesmac March 11, 2024 16:32

briansztamfater self-assigned this Mar 11, 2024

smohamedjavid approved these changes Mar 12, 2024

View reviewed changes

shivekkhurana approved these changes Mar 12, 2024

View reviewed changes

ulisesmac reviewed Mar 12, 2024

View reviewed changes

briansztamfater force-pushed the fix/watched-address-multichain branch 2 times, most recently from fee8074 to 7c10fda Compare March 14, 2024 18:34

ulisesmac approved these changes Mar 14, 2024

View reviewed changes

pavloburykh force-pushed the fix/watched-address-multichain branch from 7c10fda to 7194682 Compare March 19, 2024 17:15

mariia-skrypnyk self-assigned this Mar 19, 2024

mariia-skrypnyk added the Tested - OK label Mar 19, 2024

fix: unresponsive add watched address screen when entering a multi-ch…

211901a

…ain address

briansztamfater force-pushed the fix/watched-address-multichain branch from 7194682 to 211901a Compare March 20, 2024 16:33

briansztamfater merged commit 6363756 into develop Mar 20, 2024
6 checks passed

briansztamfater deleted the fix/watched-address-multichain branch March 20, 2024 16:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: unresponsive add watched address screen when entering a multi-chain address #19185

fix: unresponsive add watched address screen when entering a multi-chain address #19185

briansztamfater commented Mar 11, 2024

status-im-auto commented Mar 11, 2024 •

edited

Loading

smohamedjavid left a comment

status-im-auto commented Mar 12, 2024

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestDeepLinksOneDevice:

ulisesmac Mar 12, 2024 •

edited

Loading

briansztamfater Mar 14, 2024

ulisesmac Mar 14, 2024

status-im-auto commented Mar 12, 2024

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestDeepLinksOneDevice:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityOneDeviceMerged:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

mariia-skrypnyk commented Mar 19, 2024

fix: unresponsive add watched address screen when entering a multi-chain address #19185

fix: unresponsive add watched address screen when entering a multi-chain address #19185

Conversation

briansztamfater commented Mar 11, 2024

Summary

Platforms

Areas that maybe impacted

Functional

Steps to test

status-im-auto commented Mar 11, 2024 • edited Loading

Jenkins Builds

smohamedjavid left a comment

Choose a reason for hiding this comment

status-im-auto commented Mar 12, 2024

81% of end-end tests have passed

Failed tests (8)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (39)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestDeepLinksOneDevice:

ulisesmac Mar 12, 2024 • edited Loading

Choose a reason for hiding this comment

briansztamfater Mar 14, 2024

Choose a reason for hiding this comment

ulisesmac Mar 14, 2024

Choose a reason for hiding this comment

status-im-auto commented Mar 12, 2024

94% of end-end tests have passed

Failed tests (2)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (45)

Class TestDeepLinksOneDevice:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityOneDeviceMerged:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

mariia-skrypnyk commented Mar 19, 2024

status-im-auto commented Mar 11, 2024 •

edited

Loading

ulisesmac Mar 12, 2024 •

edited

Loading