don't kill metro server when its already running #19458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (13)
|
Parveshdhull
approved these changes
Mar 30, 2024
siddarthkay
force-pushed
the
dont-kill-metro
branch
from
4bdf440 to
501246f
Compare
yqrashawn
approved these changes
Apr 1, 2024
siddarthkay
force-pushed
the
dont-kill-metro
branch
from
501246f to
3156977
Compare
clauxx
approved these changes
Apr 1, 2024
siddarthkay
force-pushed
the
dont-kill-metro
branch
from
3156977 to
a4f89ec
Compare
mohsen-ghafouri
approved these changes
Apr 1, 2024
|
Waiting for integration tests to pass ...
|
siddarthkay
force-pushed
the
dont-kill-metro
branch
from
a4f89ec to
b7888d3
Compare
The killing of metro terminal upset a few people and this PR fixes that.
## Summary
Modify build step to check if metro is running already.
If so then we do not attempt to start metro again.
If not then we start metro after building android / iOS.
## Review notes
* case 1
- `make run-clojure`
- `make run-metro`
- `make run-android` or `make run-ios` should work the way it did before.
* case 2
- `make run-clojure`
- `make run-android` or `make run-ios` should also work.
## Platforms
- Android
- iOS
siddarthkay
force-pushed
the
dont-kill-metro
branch
from
b7888d3 to
800c113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The killing of metro terminal upset a few people and this PR fixes that.
Summary
Modify build step to check if metro is running already.
If so then we do not attempt to start metro again.
If not then we start metro after building android / iOS.
Review notes
make run-clojuremake run-metromake run-androidormake run-iosshould work the way it did before.make run-clojuremake run-androidormake run-iosshould also work.Platforms
status: ready