chore(wallet): move add-account functionality into its own folder #19476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (40)
|
J-Son89
force-pushed
the
jc/organise-add-account
branch
from
7aea67b to
6a51448
Compare
J-Son89
requested review from
ulisesmac and
OmarBasem
and removed request for
ulisesmac
J-Son89
commented
Apr 2, 2024
| @@ -1,4 +1,4 @@ | |||
| (ns status-im.contexts.wallet.events.collectibles | |||
There was a problem hiding this comment.
moved the collectibles file to an events.cljs file within it's collectible folder to align with the other events file
J-Son89
commented
Apr 2, 2024
| @@ -58,22 +58,24 @@ | |||
| [status-im.contexts.wallet.account.edit-account.view :as wallet-edit-account] | |||
| [status-im.contexts.wallet.account.share-address.view :as wallet-share-address] | |||
| [status-im.contexts.wallet.account.view :as wallet-accounts] | |||
| [status-im.contexts.wallet.add-address-to-watch.confirm-address.view :as | |||
| [status-im.contexts.wallet.add-account.create-account.edit-derivation-path.view :as | |||
There was a problem hiding this comment.
all of the account generation is now under add-account
smohamedjavid
approved these changes
Apr 2, 2024
shivekkhurana
approved these changes
Apr 2, 2024
OmarBasem
approved these changes
Apr 2, 2024
yeah I think we should migrate that, I'll move these folders first in this pr as it will in someways be quicker/safer to do in 2 prs. |
J-Son89
force-pushed
the
jc/organise-add-account
branch
from
6a51448 to
4999e59
Compare
ulisesmac
approved these changes
Apr 3, 2024
vkjr
approved these changes
Apr 3, 2024
J-Son89
force-pushed
the
jc/organise-add-account
branch
from
4999e59 to
6e032d7
Compare
J-Son89
commented
Apr 8, 2024
| @@ -1,4 +1,4 @@ | |||
| (ns status-im.contexts.wallet.events.saved-addresses | |||
| (ns status-im.contexts.wallet.save-address.events | |||
There was a problem hiding this comment.
@shivekkhurana -
I believe we had been going with an events file living close to its use case folder, rather than a folder of events with files for each functionality.
I moved this save-address stuff to here as I think it can be a bit more generic than within send folder too.
The flows for save address are actually used in the wallet settings also so maybe it makes sense to have it's own folder.
wdyt? 🤔
J-Son89
force-pushed
the
jc/organise-add-account
branch
2 times, most recently
from
011c292 to
2e9303f
Compare
J-Son89
commented
Apr 8, 2024
| @@ -4,11 +4,9 @@ | |||
| [react-native.background-timer :as background-timer] | |||
| [react-native.platform :as platform] | |||
| [status-im.constants :as constants] | |||
| [status-im.contexts.wallet.accounts.add-account.address-to-watch.events] | |||
There was a problem hiding this comment.
don't think these are needed here so I moved them to src/status_im/events.cljs
J-Son89
force-pushed
the
jc/organise-add-account
branch
2 times, most recently
from
3093644 to
e604392
Compare
90% of end-end tests have passedFailed tests (4)Click to expandClass TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (47)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletOneDevice:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
|
@status-im/mobile-qa - this pr just moves code around. Can I merge it, do tests look okay? 🤔 |
J-Son89
commented
Apr 9, 2024
| @@ -0,0 +1,22 @@ | |||
| (ns status-im.contexts.wallet.common.wizard.events | |||
There was a problem hiding this comment.
let's keep events in events.cljs files :)
|
hi @J-Son89 the e2e failures are not PR related. PR can be merged. Thanx! |
|
Yes, @J-Son89 - you can merge it, thank you |
J-Son89
force-pushed
the
jc/organise-add-account
branch
2 times, most recently
from
dce8eda to
7eb08ea
Compare
J-Son89
force-pushed
the
jc/organise-add-account
branch
from
7eb08ea to
9fe5e21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is the last pr of a set of wallet prs to restructure the root folder directory.
It moves all account generation pieces into add-account folder to align with figma separation.
Notes:
I think this can probably skip manual QA as it just moving files around and the compiler should really catch any issues 👍